Skip to content

fix: normalize file dependencies to ensure cache hits#2361

Merged
kovsu merged 1 commit intoflint-fyi:mainfrom
kovsu:dependencies-normalize
Feb 26, 2026
Merged

fix: normalize file dependencies to ensure cache hits#2361
kovsu merged 1 commit intoflint-fyi:mainfrom
kovsu:dependencies-normalize

Conversation

@kovsu
Copy link
Member

@kovsu kovsu commented Feb 26, 2026

PR Checklist

Overview

allFilePaths is generated by computeUseDefinitions(). And in computeUseDefinitions, the path has been normalized.
But in finalizeFileResults.ts, we didn't normalize file dependencies. So the files alway marked as uncached that is a big problem.

// readFromCache.ts
for (const filePath of allFilePaths) {
	const fileCached = cached.get(filePath);
	if (!fileCached) {
		log("No cache available for: %s", filePath);
		markAsUncached(filePath);
		continue;
	}

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2026

🦋 Changeset detected

Latest commit: 9b8a43c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@flint.fyi/core Patch
@flint.fyi/astro Patch
@flint.fyi/browser Patch
@flint.fyi/cli Patch
@flint.fyi/json-language Patch
@flint.fyi/json Patch
@flint.fyi/jsx Patch
@flint.fyi/markdown-language Patch
@flint.fyi/md Patch
@flint.fyi/next Patch
@flint.fyi/node Patch
@flint.fyi/nuxt Patch
@flint.fyi/package-json Patch
@flint.fyi/performance Patch
@flint.fyi/plugin-flint Patch
@flint.fyi/react Patch
@flint.fyi/rule-tester Patch
@flint.fyi/solid Patch
@flint.fyi/spelling Patch
@flint.fyi/text-language Patch
@flint.fyi/ts Patch
@flint.fyi/typescript-language Patch
@flint.fyi/yaml-language Patch
@flint.fyi/yaml Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flint Ready Ready Preview, Comment Feb 26, 2026 6:38am

Request Review

Copy link
Contributor

@michaelfaith michaelfaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelfaith michaelfaith added the 1 approval One team member approved; we're now waiting for a second approval or for 2 business days to pass. label Feb 26, 2026
Copy link
Member

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the caveat that if/when #2321 lands, we'll have to switch this to pathkey.

@lishaduck lishaduck added ready to merge 2+ team members approved; we're now waiting on the author to file followups and self-merge. and removed 1 approval One team member approved; we're now waiting for a second approval or for 2 business days to pass. labels Feb 26, 2026
@kovsu kovsu merged commit 011fbf2 into flint-fyi:main Feb 26, 2026
9 checks passed
@kovsu kovsu deleted the dependencies-normalize branch February 26, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge 2+ team members approved; we're now waiting on the author to file followups and self-merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants