fix: correct case sensitivity in core and e2e tests by lishaduck · Pull Request #2321 · flint-fyi/flint

lishaduck · 2026-02-15T20:40:33Z

PR Checklist

Addresses an existing open issue: fixes 🐛 Bug: CLI output shouldn't lowercase file names #2366, fixes 🐛 Bug: Lots of spelling/cspell complaints on local Flint #2367
That issue was marked as status: accepting prs
Steps in CONTRIBUTING.md were taken

Overview

❤️

vercel · 2026-02-15T20:40:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flint	Ready	Preview, Comment	Mar 11, 2026 6:14pm

changeset-bot · 2026-02-15T20:40:37Z

⚠️ No Changeset found

Latest commit: 1b16cac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lishaduck · 2026-02-15T20:41:24Z

packages/e2e/tests/utils.ts

+	// TODO[typescript>=6.0]: Remove this declaration.
+	// https://github.com/microsoft/TypeScript/pull/63046


I don't see why we shouldn't upgrade to the TS 6.0 beta, but we can do that in a different PR.

microsoft/TypeScript#63046

lishaduck · 2026-02-15T20:42:43Z

packages/e2e/tests/utils.ts

+	return stdout
+		.replace(/\\/g, "/")
+		.replace(new RegExp(RegExp.escape(normalizedCwd), "gi"), "<cwd>");


On macOS, /Users is capitalized, while the cwd our host uses isn't. This probably affected Windows as well.

CC @auvred; this continues to convince me we should preserve case in the VFS.

I'm still getting this, I'm not sure why... @barrymichaeldoyle do you know what would've changed?

- <underline><cwd>/fixtures/CONTRIBUTING.md</underline> + <underline><cwd>/fixtures/contributing.md</underline>

Also don't know if we should switch to normalizePath as Auvred suggested but I'll leave it be for now.

On macOS, /Users is capitalized, while the cwd our host uses isn't. This probably affected Windows as well.

That's why we should use normalizePath!

CC @auvred; this continues to convince me we should preserve case in the VFS.

This would be semantically incorrect. As I said earlier, fs.readFile('fIlE') === fs.readFile('file') on case insensitive file systems. VFS should match this behavior to avoid inconsistencies.

Oh, I didn't see you replied, sorry. Got lost in the noise.

That's why we should use normalizePath!

I agree that it's it's nice to use one implementation, but can you explain to my feeble brain how normalizePath helps here? Is it that it'd be lowercase everywhere?

As I said earlier, fs.readFile('fIlE') === fs.readFile('file') on case insensitive file systems. VFS should match this behavior to avoid inconsistencies.

Yes, right, I agree. What I don't understand is why we can't normalize on operations instead of in our storage. It's nice to users to be able to keep /Users or C:/ capitalized. I, personally, would be (am) annoyed if you try to lowercase my paths, because they look different and I'm used to a certain case. Windows a little unusual because path normalization anyway, but, on macOS, it just gives weird vibes.

Ok, that was a longish rant, sorry. I'm sure there's a good reason for doing it this way, and I'm happy to concede, I just don't like it yet. So please enlighten me!

they're suggesting not carrying around two paths, but only normalize at the point where you're using it (e.g. comparisons).

Ahh, I see, sorry! Well, this might actually work, but then we would need to adjust the paths returned from LinterHost methods to be non-normalized, I guess, for example from watchDirectory...

I was hoping we could leave this for a followup, but the issue is actually that we do normalize the path here (I was hoping that normalizing everywhere would help).

I'll see what I can do :)

Gave up my approach and tossed Amp on it, and well, there's a patch now, that seems to work in my testing. We do have two paths now, which I'm not thrilled with, but honestly my alternative was handrolling a hashmap with a custom equality so I'm not complaining. 😅

Haha, sorry about the late reply. But yeah I don't remember the nitty gritties of this. So I don't have strong opinions on changes here.

sorry about the late reply. But yeah I don't remember the nitty gritties of this.

You're good! It turns out it wasn't actually an issue from #2141 but rather from #1605(?) that the merge of #2141 caught.

vitest.config.ts

michaelfaith

Looks good to me 👍

packages/e2e/tests/cspell/cspell.test.ts

packages/e2e/tests/utils.ts

lishaduck · 2026-02-20T04:47:27Z

Ooops. Sorry for the rebase.

Amp-Thread-ID: https://ampcode.com/threads/T-019c8802-4a92-719e-ad17-2a4c539dcce4 Co-authored-by: Amp <amp@ampcode.com>

kovsu · 2026-03-01T15:17:18Z

can you pull this down and check #2361 still works?

@lishaduck Sorry for the late response. I don’t think it’s working at the moment. It might be because normalize() was used in places where pathKey() should have been used instead.

JoshuaKGoldberg · 2026-03-01T16:37:19Z

fix: improve e2e tests

Just confirming: this PR does more than just e2e tests, it actually fixes case sensitivity things right? And fixes #2367?

lishaduck · 2026-03-01T18:44:01Z

Just confirming: this PR does more than just e2e tests, it actually fixes case sensitivity things right? And fixes #2367?

Right. It was originally fixing the tests' case-sensitivity but then I realized the actual case-sensitivity was broken so that all got rolled into this.

auvred

I like the "path key" terminology! Much clearer than TypeScript's file name and path. Left a couple minor questions, nothing critical (sorry it took me so long to review)

packages/core/src/host/createVFSLinterHost.ts

packages/utils/src/normalizePath.ts

JoshuaKGoldberg

Hell yeah! Nothing from me beyond what Auvred's already said in review. This is looking great!

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com> Also a bit of Amp to fix what that broke: Amp-Thread-ID: https://ampcode.com/threads/T-019cdaf0-487a-7656-9652-8d879c64f373 Co-authored-by: Amp amp@ampcode.com

auvred

10/10!

lishaduck · 2026-03-12T12:31:40Z

I'm going to merge given how much this fixes.

vercel bot deployed to Preview February 15, 2026 20:42 View deployment

lishaduck commented Feb 15, 2026

View reviewed changes

lishaduck force-pushed the ser-ansi-color branch 2 times, most recently from 1091bcd to be836c3 Compare February 15, 2026 20:47

vercel bot deployed to Preview February 15, 2026 20:50 View deployment

michaelfaith approved these changes Feb 15, 2026

View reviewed changes

michaelfaith added 1 approval One team member approved; we're now waiting for a second approval or for 2 business days to pass. ready to merge 2+ team members approved; we're now waiting on the author to file followups and self-merge. labels Feb 15, 2026

lishaduck mentioned this pull request Feb 20, 2026

fix: update e2e test snapshots to new format #2331

Closed

vercel bot deployed to Preview February 20, 2026 04:24 View deployment

lishaduck commented Feb 20, 2026

View reviewed changes

packages/e2e/tests/cspell/cspell.test.ts Show resolved Hide resolved

packages/e2e/tests/cspell/cspell.test.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview February 20, 2026 04:34 View deployment

vercel bot deployed to Preview February 20, 2026 04:44 View deployment

lishaduck commented Feb 20, 2026

View reviewed changes

packages/e2e/tests/utils.ts Outdated Show resolved Hide resolved

lishaduck force-pushed the ser-ansi-color branch from 653279a to 60dc7df Compare February 20, 2026 04:47

vercel bot deployed to Preview February 20, 2026 04:48 View deployment

lishaduck added 3 commits February 21, 2026 09:55

fix: improve e2e tests

c8927c0

move normalizePath to utils

7f8ae80

wait is exporting all of core intentional?

b23690a

lishaduck force-pushed the ser-ansi-color branch from 60dc7df to b23690a Compare February 21, 2026 15:55

vercel bot deployed to Preview February 21, 2026 15:57 View deployment

Merge branch 'main' into ser-ansi-color

a72e513

vercel bot deployed to Preview February 22, 2026 23:31 View deployment

fix: don't normalize case by default

59d6e01

Amp-Thread-ID: https://ampcode.com/threads/T-019c8802-4a92-719e-ad17-2a4c539dcce4 Co-authored-by: Amp <amp@ampcode.com>

lishaduck force-pushed the ser-ansi-color branch from c312723 to 59d6e01 Compare February 23, 2026 02:42

lishaduck mentioned this pull request Feb 23, 2026

🐛 Bug: flint exports all of core #2341

Open

2 tasks

vercel bot deployed to Preview February 23, 2026 02:45 View deployment

JoshuaKGoldberg mentioned this pull request Mar 1, 2026

🐛 Bug: Lots of spelling/cspell complaints on local Flint #2367

Closed

2 tasks

This was referenced Mar 1, 2026

🐛 Bug: CLI output shouldn't lowercase file names #2366

Closed

🚀 Feature: Performance #1320

Open

vercel bot deployed to Preview March 6, 2026 15:07 View deployment

Merge branch 'main' into ser-ansi-color

6bc68ec

lishaduck force-pushed the ser-ansi-color branch from 6e4b900 to 6bc68ec Compare March 7, 2026 02:36

vercel bot deployed to Preview March 7, 2026 02:37 View deployment

lishaduck mentioned this pull request Mar 7, 2026

perf: hunt down more serial awaits #2350

Merged

3 tasks

auvred requested changes Mar 7, 2026

View reviewed changes

packages/core/src/host/createVFSLinterHost.ts Outdated Show resolved Hide resolved

packages/core/src/host/createVFSLinterHost.ts Show resolved Hide resolved

JoshuaKGoldberg changed the title ~~fix: improve e2e tests~~ fix: correct case sensitivity in core and e2e tests Mar 7, 2026

JoshuaKGoldberg reviewed Mar 7, 2026

View reviewed changes

packages/utils/src/normalizePath.ts Show resolved Hide resolved

JoshuaKGoldberg approved these changes Mar 7, 2026

View reviewed changes

JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Mar 11, 2026

Merge branch 'main' into ser-ansi-color

15396e4

vercel bot deployed to Preview March 11, 2026 02:57 View deployment

vercel bot deployed to Preview March 11, 2026 04:00 View deployment

cleanup

1b16cac

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com> Also a bit of Amp to fix what that broke: Amp-Thread-ID: https://ampcode.com/threads/T-019cdaf0-487a-7656-9652-8d879c64f373 Co-authored-by: Amp amp@ampcode.com

lishaduck force-pushed the ser-ansi-color branch from 876233e to 1b16cac Compare March 11, 2026 18:10

vercel bot deployed to Preview March 11, 2026 18:14 View deployment

auvred approved these changes Mar 12, 2026

View reviewed changes

auvred added ready to merge 2+ team members approved; we're now waiting on the author to file followups and self-merge. and removed status: waiting for author Needs an action taken by the original poster labels Mar 12, 2026

lishaduck merged commit 9f4d531 into main Mar 12, 2026
8 checks passed

lishaduck deleted the ser-ansi-color branch March 12, 2026 12:31

lishaduck mentioned this pull request Mar 13, 2026

ci: run tests over a matrix #2429

Open

3 tasks

JoshuaKGoldberg mentioned this pull request Mar 14, 2026

🐛 Bug: RuleTester report errors in wrong test cases #2436

Closed

2 tasks

		// TODO[typescript>=6.0]: Remove this declaration.
		// https://github.com/microsoft/TypeScript/pull/63046

Conversation

lishaduck commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

vercel bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lishaduck Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaelfaith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lishaduck commented Feb 20, 2026

Uh oh!

kovsu commented Mar 1, 2026

Uh oh!

JoshuaKGoldberg commented Mar 1, 2026

Uh oh!

lishaduck commented Mar 1, 2026

Uh oh!

auvred left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

auvred left a comment

Choose a reason for hiding this comment

Uh oh!

lishaduck commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lishaduck commented Feb 15, 2026 •

edited

Loading

vercel bot commented Feb 15, 2026 •

edited

Loading

changeset-bot bot commented Feb 15, 2026 •

edited

Loading

lishaduck Feb 20, 2026 •

edited

Loading