fix(typescript): set original file's script kind to match the service script's in proxyCreateProgram#299
Merged
johnsoncodehk merged 1 commit intovolarjs:masterfrom Jan 31, 2026
Conversation
proxyCreateProgram
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In flint-fyi/flint#1179 I'm using
proxyCreateProgramto patch the programs created by the Project Service. Parsed files are stored in TypeScript's document registry. When a file is parsed and later updated in the Project Service, it tries to reuse the old document, but the script kinds don't match, so TS fails with:If we set the original file's script kind to match the service script's script kind, then everything works as expected: https://github.com/flint-fyi/flint/blob/75d19831b7476b89271989fbe25e9d1593d4e628/patches/%40volar__typescript%402.4.27.patch