-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: Full support of AGP 8 #11699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Full support of AGP 8 #11699
Conversation
|
@russellwheatley Here it is, the updated version of #11318 I would also appreciate if you review #11671 as well. |
|
@vbuberen - thank you for the PRs 🥳 . I will take a look at them next week 😄 |
|
@vbuberen - The CI is failing because of the need for I've built it locally and it doesn't work with |
I will check it out a bit later today. |
|
I made a typo there 🤦🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @vbuberen 🥳
Co-authored-by: Russell Wheatley <[email protected]>
Description
This PR is a replacement for #11318 as it was agreed in that PR. Opened another PR as don't have access to push anything to that other fork used to create #11318.
Summary of changes and things to note:
buildFeaturesblock in allbuild.gradlefiles for support of AGP 8.Dropped step to install Java from CI as it is pre-installed on Github runners: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md UPD: Looks like workflow can't pick Java 17 on its own even though it is installed, so brought back the Java setup step.compileSdkVersionusecompileSDK). Note, this would require projects using plugins to have at least AGP 7 as it mentioned here: https://developer.android.com/about/versions/13/setup-sdk3.xversions of AGP after this PR build speed should improve for such packages.jcenter()as it is not reliable and replaced withmavenCentral().-jdk7or-jdk8as it is not needed for quite a long time already and since release1.8.xis the default required way of declaring Kotlin dependency.annotationAndroid dependency in all plugins.gradlefolders in packages where they are not needed.build.gradlefiles so they have the same position of blocks across plugins as it was confusing to update code in different places for every plugin.Related Issues
Closes #11266
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?