Skip to content

Conversation

@vbuberen
Copy link
Contributor

@vbuberen vbuberen commented Sep 28, 2023

Description

Jetifier is needed to provide compatibility between old support packages and modern androidx ones: https://developer.android.com/tools/jetifier
If project has no support libraries in its dependencies it makes no sense to have Jetifier enabled as it influences the build speed:
https://adambennett.dev/2020/08/disabling-jetifier/
https://developer.android.com/build/optimize-your-build#disable-the-jetifier-flag

Thus, dropping Jetifier. Will open a series of PRs on this topic to not change all packages at once.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@vbuberen
Copy link
Contributor Author

Can be closed in favor of #11699 which contains the same change

@vbuberen vbuberen closed this Oct 13, 2023
@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant