feat(app_check): Use Android dependencies from Firebase BOM #11671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
commented
Oct 5, 2023
| implementation 'com.google.firebase:firebase-appcheck-debug:16.1.0' | ||
| implementation 'com.google.firebase:firebase-appcheck-debug' | ||
| implementation 'com.google.firebase:firebase-appcheck-playintegrity' | ||
| implementation 'com.google.firebase:firebase-appcheck-safetynet' |
Contributor
Author
There was a problem hiding this comment.
Moved it to the bottom as it is deprecated and, potentially, is a subject for removal in future: https://developer.android.com/training/safetynet/deprecation-timeline
10 tasks
russellwheatley
approved these changes
Oct 16, 2023
Lyokone
approved these changes
Oct 16, 2023
Contributor
|
Thanks for fixing :) |
guide-loclt
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Oct 29, 2023
…#11671) * feat(app_check): Use Android dependencies from Firebase BOM * Update build.gradle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
App Check dependencies are available in Firebase BOM for some time already, so it makes sense to keep versions of App Check artifacts aligned with what BOM provides. Moreover, seems like current version of App Check for Flutter had quite old corresponding Android dependencies, so this change will also bump version of App Check Android.
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?