Skip to content

fix: Xcode/OS matrices in reusable SPM and CP workflows #15732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncooke3 merged 29 commits into from
Jan 23, 2026
Merged

fix: Xcode/OS matrices in reusable SPM and CP workflows #15732

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
36504c3
fix: Xcode/OS matrices in reusable SPM and CP workflows
ncooke3 Jan 16, 2026
df64026
macos14 testing
ncooke3 Jan 16, 2026
34ea0b0
install sims
ncooke3 Jan 20, 2026
1a68866
Apply suggestion from @ncooke3
ncooke3 Jan 20, 2026
25a433e
Update .github/workflows/_cocoapods.yml
ncooke3 Jan 20, 2026
8a021d1
Update .github/workflows/_spm.yml
ncooke3 Jan 20, 2026
5e9ebe2
fix
ncooke3 Jan 20, 2026
0001c77
can't upload xcresult when build fails
ncooke3 Jan 20, 2026
c006e03
fix watchos
ncooke3 Jan 20, 2026
a29f62e
fix: scripts/setup_spm.sh should handle ghost commits (#15742)
ncooke3 Jan 20, 2026
82c49aa
Update .github/workflows/_cocoapods.yml
ncooke3 Jan 21, 2026
2a30b92
Update .github/workflows/_spm.yml
ncooke3 Jan 21, 2026
3fa9a86
Update _cocoapods.yml
ncooke3 Jan 21, 2026
6b438e1
Update _spm.yml
ncooke3 Jan 21, 2026
3b99235
Update _spm.yml
ncooke3 Jan 21, 2026
99700cc
Update _spm.yml
ncooke3 Jan 21, 2026
b3e48bf
fixes
ncooke3 Jan 21, 2026
22d7b6a
fixes
ncooke3 Jan 22, 2026
4551e7b
fixes
ncooke3 Jan 22, 2026
9ee7813
Apply suggestions from code review (1)
ncooke3 Jan 22, 2026
8b10083
Apply suggestion from @ncooke3
ncooke3 Jan 22, 2026
95a340c
Apply suggestion from @ncooke3
ncooke3 Jan 22, 2026
19fe58b
Apply suggestion from @ncooke3
ncooke3 Jan 22, 2026
9c59108
fix: skip builds earlier in _cocoapods.yml, when applicable (#15753)
ncooke3 Jan 23, 2026
4424478
Update scripts/setup_quickstart.sh
ncooke3 Jan 23, 2026
c9c7a06
Apply suggestion from @ncooke3
ncooke3 Jan 23, 2026
341db02
Apply suggestion from @ncooke3
ncooke3 Jan 23, 2026
2669c12
Move to Xcode 26.2
ncooke3 Jan 23, 2026
1eacb6f
Revert "Move to Xcode 26.2"
ncooke3 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/_cocoapods.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,18 @@ jobs:
if: (github.repository == 'firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name)
strategy:
matrix:
os: [macos-15]
xcode: [Xcode_16.4]
os: [macos-15, macos-26]
xcode: [Xcode_16.4, Xcode_26.1]
Comment thread
ncooke3 marked this conversation as resolved.
platform: [iOS, tvOS, macOS, watchOS]
exclude:
- os: macos-15
xcode: Xcode_26.1
Comment thread
ncooke3 marked this conversation as resolved.
- os: macos-26
xcode: Xcode_16.4
include:
- os: macos-15
xcode: Xcode_16.2
platform: iOS
Comment thread
ncooke3 marked this conversation as resolved.
Outdated
- os: macos-14
xcode: Xcode_16.2
platform: iOS
Expand All @@ -142,6 +150,14 @@ jobs:
command: scripts/setup_bundler.sh
- name: Xcode
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
- name: Install simulators in case they are missing.
if: matrix.target != 'macOS'
Comment thread
ncooke3 marked this conversation as resolved.
Outdated
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
with:
timeout_minutes: 15
max_attempts: 5
retry_wait_seconds: 120
Comment thread
ncooke3 marked this conversation as resolved.
Comment thread
ncooke3 marked this conversation as resolved.
command: sudo xcodebuild -downloadPlatform ${{ matrix.platform }}
- name: Set conditional environment variable, if needed.
if: inputs.product == 'FirebaseAuth'
run: echo "FIREBASE_CI=true" >> $GITHUB_ENV
Expand Down
23 changes: 18 additions & 5 deletions .github/workflows/_spm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,20 @@ jobs:
FIREBASE_IS_NIGHTLY_TESTING: ${{ inputs.is_nightly && '1' || '' }}
strategy:
matrix:
os: [macos-15]
xcode: [Xcode_16.4]
os: [macos-15, macos-26]
xcode: [Xcode_16.4, Xcode_26.1]
Comment thread
ncooke3 marked this conversation as resolved.
platform: [iOS, tvOS, macOS, watchOS, catalyst, visionOS]
exclude:
- os: macos-15
xcode: Xcode_26.1
Comment thread
ncooke3 marked this conversation as resolved.
- os: macos-26
xcode: Xcode_16.4
include:
- os: macos-14
- os: macos-15
xcode: Xcode_16.2
platform: iOS
Comment thread
ncooke3 marked this conversation as resolved.
Outdated
- os: macos-26
xcode: Xcode_26.1
- os: macos-14
xcode: Xcode_16.2
platform: iOS
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -115,6 +120,14 @@ jobs:
key: ${{needs.spm-package-resolved.outputs.cache_key}}
- name: Xcode
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
- name: Install simulators in case they are missing.
if: matrix.target != 'macOS'
Comment thread
ncooke3 marked this conversation as resolved.
Outdated
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
with:
timeout_minutes: 15
max_attempts: 5
retry_wait_seconds: 120
Comment thread
ncooke3 marked this conversation as resolved.
command: sudo xcodebuild -downloadPlatform ${{ matrix.platform }}
- name: Run setup command, if needed.
if: inputs.setup_command != ''
run: ${{ inputs.setup_command }}
Expand Down
Loading