-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: Xcode/OS matrices in reusable SPM and CP workflows #15732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
36504c3
df64026
34ea0b0
1a68866
25a433e
8a021d1
5e9ebe2
0001c77
c006e03
a29f62e
82c49aa
2a30b92
3fa9a86
6b438e1
3b99235
99700cc
b3e48bf
22d7b6a
4551e7b
9ee7813
8b10083
95a340c
19fe58b
9c59108
4424478
c9c7a06
341db02
2669c12
1eacb6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,8 +72,6 @@ - (void)testDictionaryRepresentation { | |
| NSDictionary* testDict = [_userDefaults dictionaryRepresentation]; | ||
| NSLog(@"%@", testDict); | ||
|
|
||
| NSLog(@"foooo"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😆 I'm not sure we want to clean this up. I like it. |
||
|
|
||
| XCTAssertEqualObjects(testDict, expectedTestDict, @""); | ||
| } | ||
|
|
||
|
|
||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixes a bug that reappeared in this PR where the quickstart script that updates the SPM dependency to point to this PR fails because Github creates a "ghost" commit that does not exist outside of the PR's CI context. This is a problem since the quickstart needs to point to a valid commit on the remote of the Firebase repo. This solution seems to work so far. |
Uh oh!
There was an error while loading. Please reload this page.