Skip to content

Comments

fix: Xcode/OS matrices in reusable SPM and CP workflows#15732

Merged
ncooke3 merged 29 commits intomainfrom
nc/reusable-xcode-strat
Jan 23, 2026
Merged

fix: Xcode/OS matrices in reusable SPM and CP workflows#15732
ncooke3 merged 29 commits intomainfrom
nc/reusable-xcode-strat

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 16, 2026

Both reusable workflows will test against:

  1. Xcode 16.2 on macOS 14 for iOS only.
  2. Xcode 16.2 on macOS 15 for iOS only.
  3. Xcode 16.4 on macOS 15 for all platforms.
  4. Xcode 26.1 on macOS 26 for all platforms.

Contexts:

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@ncooke3 ncooke3 added this to the 12.9.0 - M176 milestone Jan 16, 2026
@ncooke3

This comment was marked as outdated.

@ncooke3

This comment was marked as outdated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a bug that reappeared in this PR where the quickstart script that updates the SPM dependency to point to this PR fails because Github creates a "ghost" commit that does not exist outside of the PR's CI context. This is a problem since the quickstart needs to point to a valid commit on the remote of the Firebase repo. This solution seems to work so far.

@ncooke3 ncooke3 marked this pull request as ready for review January 23, 2026 01:29
@ncooke3 ncooke3 requested a review from a team as a code owner January 23, 2026 01:29
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 23, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Xcode and OS matrices for reusable CI workflows. The changes involve updating simulator versions and build flags in build.sh to support newer Xcode versions, and improving the logic in scripts/setup_quickstart.sh to correctly obtain the commit SHA for pull requests. A debug log was also removed. The changes are sound and improve the CI setup. I've added one suggestion to make the script that retrieves the commit SHA more robust.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
NSDictionary* testDict = [_userDefaults dictionaryRepresentation];
NSLog(@"%@", testDict);

NSLog(@"foooo");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 I'm not sure we want to clean this up. I like it.

@ncooke3
Copy link
Member Author

ncooke3 commented Jan 23, 2026

I removed the macos-15 x Xcode 16.2 testing since it seems to be flaky (I think due to iOS 18.3 simulator networking issues).

I will let the current CI finish and then try moving to Xcode 26.2 to smoke test that version.

@ncooke3 ncooke3 merged commit cf18404 into main Jan 23, 2026
274 of 275 checks passed
@ncooke3 ncooke3 deleted the nc/reusable-xcode-strat branch January 23, 2026 19:13
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 23, 2026

Going to do a follow-up with Xcode 26.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants