Skip to content

minor fixes#1176

Merged
akphi merged 5 commits intofinos:masterfrom
akphi:miop
May 23, 2022
Merged

minor fixes#1176
akphi merged 5 commits intofinos:masterfrom
akphi:miop

Conversation

@akphi
Copy link
Contributor

@akphi akphi commented May 23, 2022

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2022

🦋 Changeset detected

Latest commit: 075b18e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-manual-tests Patch
@finos/legend-graph Patch
@finos/legend-studio Patch
@finos/legend-application Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-extension-mapping-generation Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-query Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-query-app Patch
@finos/legend-taxonomy-app Patch
@finos/legend-studio-deployment Patch
@finos/legend-query-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@MauricioUyaguari MauricioUyaguari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now this is a minor fix PR :)

@akphi
Copy link
Contributor Author

akphi commented May 23, 2022

now this is a minor fix PR :)

image

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1176 (075b18e) into master (190e385) will decrease coverage by 0.20%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
- Coverage   42.66%   42.45%   -0.21%     
==========================================
  Files        1140     1140              
  Lines       50232    50247      +15     
  Branches    11521    11524       +3     
==========================================
- Hits        21430    21333      -97     
- Misses      28730    28843     +113     
+ Partials       72       71       -1     
Impacted Files Coverage Δ
.../changeDetection/StoreRelational_ObserverHelper.ts 28.40% <ø> (ø)
...izationHelpers/V1_ConnectionSerializationHelper.ts 70.27% <ø> (+3.24%) ⬆️
...egend-studio/src/components/editor/ActivityBar.tsx 57.50% <ø> (-1.76%) ⬇️
...aphModifier/StoreRelational_GraphModifierHelper.ts 34.39% <33.33%> (-0.05%) ⬇️
...tion-editor/RelationalDatabaseConnectionEditor.tsx 28.04% <50.00%> (+0.30%) ⬆️
...element-editor-state/mapping/MappingEditorState.ts 39.50% <50.00%> (+0.14%) ⬆️
...e/relational/connection/DatasourceSpecification.ts 71.66% <100.00%> (+11.32%) ⬆️
...elational/connection/V1_DatasourceSpecification.ts 76.92% <100.00%> (+10.25%) ⬆️
...rmation/pureGraph/from/V1_ConnectionTransformer.ts 75.60% <100.00%> (+4.18%) ⬆️
...to/helpers/V1_RelationalConnectionBuilderHelper.ts 59.79% <100.00%> (+5.05%) ⬆️
... and 21 more

@akphi akphi merged commit b911ee7 into finos:master May 23, 2022
@akphi akphi deleted the miop branch May 23, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-present CLA Signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments