Add proxy params to BigQuery DataSource#1010
Merged
MauricioUyaguari merged 8 commits intofinos:masterfrom May 23, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 726df0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
abhishoya-gs
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
+ Coverage 42.01% 42.39% +0.37%
==========================================
Files 1008 1045 +37
Lines 45986 47027 +1041
Branches 10592 10709 +117
==========================================
+ Hits 19321 19937 +616
- Misses 26589 27021 +432
+ Partials 76 69 -7
|
abhishoya-gs
requested review from
MauricioUyaguari,
akphi and
pierredebelen
as code owners
MauricioUyaguari
requested changes
Apr 12, 2022
...io/src/components/editor/edit-panel/connection-editor/RelationalDatabaseConnectionEditor.tsx
Show resolved
Hide resolved
gayathrir11
reviewed
Apr 18, 2022
MauricioUyaguari
requested changes
Apr 18, 2022
Member
|
@abhishoya-gs is this ready for review again? If so could you move it out of the draft state. Thanks |
MauricioUyaguari
approved these changes
May 20, 2022
akphi
pushed a commit
to akphi/legend-studio
that referenced
this pull request
May 23, 2022
7 tasks
akphi
pushed a commit
to akphi/legend-studio
that referenced
this pull request
May 23, 2022
akphi
pushed a commit
that referenced
this pull request
May 23, 2022
* temporarily disable grammar roundtrip test for persistence DSL * fix github actions dep problem * properly reveal compilation error for relational property mappings * fix broken test introduced by #1010 * temporarily hide global test runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding the proxy parameters to BigQuery DataSource Specification
Engine PR: finos/legend-engine#618
Pure PR: finos/legend-pure#499
How did you test this change?