fix(generator-cli): sign every local-only commit when pushing, not just HEAD#16931
Merged
Merged
Conversation
…st HEAD Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
tstanmay13
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: Refs
Auth0 reported that on replay-generated PRs (e.g. auth0/auth0.net#1043) the first commit (
[fern-generated] Update SDK) is unsigned while the head commit ([fern-replay] Applied customizations) is Verified.Root cause:
pushSignedCommitonly recreates the branch HEAD viaoctokit.git.createCommit(which GitHub signs with the App key). Any earlier local commits on the branch — the[fern-generated]commit (and[fern-autoversion]when present) — are only uploaded as raw git objects via the temp ref, so they reach the remote unsigned.Fix: sign the whole local-only commit chain:
The branch ref is then updated to the signed head, so every commit on the PR shows as Verified. Falls back to signing HEAD only (previous behavior) when no remote-tracking refs are available or the chain exceeds a 20-commit safety cap.
Changes Made
packages/generator-cli/src/pipeline/github/pushSignedCommit.ts: extractsignLocalCommitChain— recreates every local-only commit via the GitHub API, re-parenting each onto its signed predecessorpackages/commons/github/src/ClonedRepository.ts: addgetLocalOnlyCommits(),getCommitMessage(sha),getCommitParents(sha)packages/generator-cli/changes/unreleased/sign-all-local-commits.yml: changelog entry (fix)Testing
verification.reason: unsignedwhile the replay commit isvalidLink to Devin session: https://app.devin.ai/sessions/b913483a939e40dab7e227be14eb6135
Requested by: @cadesark