feat: add filters to restrict enrollment FAN-41 - #5
Merged
MaferMazu merged 1 commit intoSep 28, 2022
Conversation
MaferMazu
marked this pull request as ready for review
August 30, 2022 23:59
MaferMazu
force-pushed
the
dev/add-filters-to-restrict-enrollment
branch
from
September 15, 2022 05:28
eb7c7e8 to
0e12aad
Compare
MaferMazu
force-pushed
the
dev/add-filters-to-restrict-enrollment
branch
from
September 26, 2022 18:52
4c013ac to
7326f36
Compare
Contributor
Author
|
This PR is ready for review.
If you are okey I am going to squash the commits in this PR and merge when I have the approval |
felipemontoya
approved these changes
Sep 27, 2022
felipemontoya
left a comment
Member
There was a problem hiding this comment.
I think this covers my previous comments. Thanks @MaferMazu
The commits in detail: feat: add model and admin for DomainsAllowedPerCourse feat: add FilterEnrollmentByDomain Revert "feat: add model and admin for DomainsAllowedPerCourse" This reverts commit 54d8f99. feat: add wrapper to obtain allowed_domains in other_course_settings refactor: use "filter_enrollment_by_domain_list" instead domains_allowed fix: issues with import and issues with obtain filter_enrollment_by_domain_list feat: allow exception translation and allow match with subdomains
MaferMazu
force-pushed
the
dev/add-filters-to-restrict-enrollment
branch
from
September 28, 2022 04:01
7326f36 to
584b110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the feature FAN-41: NAU Academies - restrict course enrollment by email domain.
User interface when a user can't enroll (en)
User interface when a user can't enroll (pt-pt)
Internal logs
Dependencies
How to test
In #6 I added tests.
In tutor:
nau/lilac.masterbranch