fix(FAN-41): catch the EnrollmentNotAllowed and InvalidEnrollmentAttribute - #6
Merged
Conversation
…ception for FAN-41
MaferMazu
force-pushed
the
nau/fix-fan41
branch
from
December 14, 2022 22:13
43ff51f to
7b9b377
Compare
MaferMazu
marked this pull request as ready for review
December 14, 2022 22:34
felipemontoya
approved these changes
Dec 15, 2022
felipemontoya
left a comment
Member
There was a problem hiding this comment.
This looks exactly as we discussed in the call.
The code is tested in a development environment and the screenshots are pasted here. I think we are good to merge. Just waiting for Ivo's approval
igobranco
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR catches EnrollmentNotAllowed and InvalidEnrollmentAttribute exceptions in favor of returning a status 400 bad request. This fixes the 500 error when you make a post request to the /api/enrollment/v1/enrollment.
How to test
{"course_details":{"course_id": "<your_course_id>"}}, and you are going to get an error 400 instead of 500.Before
Response in /api/enrollment/v1/enrollment
Logs
After
Response in /api/enrollment/v1/enrollment
Logs