test: add wrapper and filter tests FAN-58 - #6
Merged
Conversation
MaferMazu
force-pushed
the
dev/add-filter-tests
branch
2 times, most recently
from
September 16, 2022 05:15
86a052a to
acb3e4c
Compare
MaferMazu
force-pushed
the
dev/add-filter-tests
branch
2 times, most recently
from
September 25, 2022 22:14
5d650a4 to
a619516
Compare
MaferMazu
force-pushed
the
dev/add-filters-to-restrict-enrollment
branch
from
September 26, 2022 18:52
4c013ac to
7326f36
Compare
MaferMazu
force-pushed
the
dev/add-filter-tests
branch
from
September 26, 2022 18:54
957e5d3 to
755a4c4
Compare
MaferMazu
marked this pull request as ready for review
September 27, 2022 13:35
MaferMazu
force-pushed
the
dev/add-filters-to-restrict-enrollment
branch
from
September 28, 2022 04:01
7326f36 to
584b110
Compare
MaferMazu
force-pushed
the
dev/add-filter-tests
branch
from
September 28, 2022 04:22
755a4c4 to
1d28e1c
Compare
MaferMazu
changed the base branch from
dev/add-filters-to-restrict-enrollment
to
nau/lilac.master
September 28, 2022 04:23
Member
|
@MaferMazu do you run this tests from the tutor dev bash? Or are you running the out of the containers? |
Contributor
Author
|
@felipemontoya I ran it out of the containers |
felipemontoya
approved these changes
Sep 29, 2022
felipemontoya
left a comment
Member
There was a problem hiding this comment.
I think this is better to merge this sooner rather than waiting for long with the branch open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for the PR #5
How to test
export DJANGO_SETTINGS_MODULE='nau_openedx_extensions.settings.test'make python-testNotes for next steps and later improvements
pylint <file-name>)