fix(driver/kmod): fixed tracepoint detach to avoid dmesg errors.#597
Merged
fix(driver/kmod): fixed tracepoint detach to avoid dmesg errors.#597
Conversation
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
poiana
added
release-note-none
dco-signoff: yes
kind/bug
Contributor
Author
|
/milestone 3.0.0+driver |
FedeDP
commented
Sep 12, 2022
| #if LINUX_VERSION_CODE > KERNEL_VERSION(2, 6, 20) | ||
| tracepoint_synchronize_unregister(); | ||
| #endif | ||
| g_tracepoints_attached = 0; |
Contributor
Author
There was a problem hiding this comment.
We are already cleaning up g_tracepoints_attached bits in force_tp_set.
FedeDP
commented
Sep 12, 2022
| { | ||
| if (ret == 0) | ||
| { | ||
| g_tracepoints_attached &= ~(1 << idx); |
Contributor
Author
There was a problem hiding this comment.
Actually clean up disabled tp bits.
leogr
approved these changes
Sep 12, 2022
Contributor
|
LGTM label has been added. DetailsGit tree hash: 186a4a51cb23b6718484678c3dd44819aa325ef9 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
What this PR does / why we need it:
Avoid some dmesg errors by keeping
g_tracepoints_attachedin sync with real values.Extracted from #582
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: