Skip to content

fix(driver/kmod): fixed tracepoint detach to avoid dmesg errors. #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poiana merged 1 commit into from
Sep 12, 2022
Merged

fix(driver/kmod): fixed tracepoint detach to avoid dmesg errors. #597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions driver/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,6 @@ static int ppm_release(struct inode *inode, struct file *filp)
#if LINUX_VERSION_CODE > KERNEL_VERSION(2, 6, 20)
tracepoint_synchronize_unregister();
#endif
g_tracepoints_attached = 0;
Copy link
Copy Markdown
Contributor Author

@FedeDP FedeDP Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already cleaning up g_tracepoints_attached bits in force_tp_set.


/*
* Reset tracepoint counter
Expand Down Expand Up @@ -744,7 +743,18 @@ static int force_tp_set(u32 new_tp_set, u32 max_val)
}
else
{
pr_err("can't create the %s tracepoint\n", tp_names[idx]);
pr_err("can't attach the %s tracepoint\n", tp_names[idx]);
}
}
else
{
if (ret == 0)
{
g_tracepoints_attached &= ~(1 << idx);
Copy link
Copy Markdown
Contributor Author

@FedeDP FedeDP Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually clean up disabled tp bits.

}
else
{
pr_err("can't detach the %s tracepoint\n", tp_names[idx]);
}
}
}
Expand Down