Skip to content

new: runtime tracepoints management #582

Merged
poiana merged 3 commits intomasterfrom
new/runtime_tp_management
Oct 26, 2022
Merged

new: runtime tracepoints management #582
poiana merged 3 commits intomasterfrom
new/runtime_tp_management

Conversation

@FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 6, 2022

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap

/area libsinsp

Does this PR require a change in the driver versions?

/version driver-API-version-major

new ioctl introduced in kmod.

What this PR does / why we need it:

This PR completes part of #521 allowing even tracepoints to be runtime modified, just like we allow it for ppm_sc.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 12, 2022

Rebased on top of master.

@FedeDP FedeDP force-pushed the new/runtime_tp_management branch from 8e5fc10 to 57cde9a Compare September 12, 2022 11:01
@FedeDP FedeDP force-pushed the new/runtime_tp_management branch from 57cde9a to 89ae34b Compare September 20, 2022 12:18
@poiana poiana added size/XXL and removed size/XL labels Sep 20, 2022
@FedeDP FedeDP force-pushed the new/runtime_tp_management branch from 81a8801 to c34287c Compare October 4, 2022 07:23
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 5, 2022

/milestone 0.10.0

@FedeDP FedeDP added this to the 0.10.0 milestone Oct 5, 2022
This is the same API we introduced for runtime ppm_sc management in #521,
but for tracepoints.
It is implemented for kmod, bpf and modern_bpf.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the new/runtime_tp_management branch from c34287c to 9230c39 Compare October 25, 2022 15:47
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 25, 2022

Rebased on top of master!

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the new/runtime_tp_management branch from e0a11c1 to f23ca74 Compare October 26, 2022 07:41
@poiana
Copy link
Contributor

poiana commented Oct 26, 2022

LGTM label has been added.

DetailsGit tree hash: 714f988c4ec816d4388d53c0b4976c7832e9948f

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0f97775 into master Oct 26, 2022
@poiana poiana deleted the new/runtime_tp_management branch October 26, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants