Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Merge dev branch into main #2476

Merged
merged 7 commits into from
Nov 4, 2024
Merged

[WIP] Merge dev branch into main #2476

merged 7 commits into from
Nov 4, 2024

Commits on Oct 29, 2024

  1. --[Bugfix] - Scene Reset Redundancy (#2470)

    * --modify reset() to not perform redundant object re-placement
    After successful scene creation, reset is called, but the objects have all already been placed in their initial positions.
    
    * --fix bindings
    Don't expose the boolean in reset to python, should only be consumed from Simulator::reconfigure
    jturner65 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d55b1ee View commit details
    Browse the repository at this point in the history
  2. --[BE] - Add ability to filter Configuration subconfigs (#2471)

    * --add subconfig filtering process.
    This function will remove any values and subconfigs from a Configuration that match those found within a passed Configuration.
    * --minor naming clarification
    * --expand Configuration tests to test filtering; rename test
    Test only tests Configurations, so name appropriately
    jturner65 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7275866 View commit details
    Browse the repository at this point in the history
  3. --[Bugfix] - Address ObjectInstanceAttributes save issues (#2472)

    * --access init instance attributes for an rigid/AO via const ref or copy
    * --access sim directly to query for defaultCOMCorrection state
    So that objects added to an existing scene will use the correct defaultCOMCorrection state.
    * --verify requested type is appropriate
    * --add queries for current state of Configuration fields
    Query whether a field is a default value, a hidden value or backed by an enum (i.e. 'translated')
    * --properly set enum-backed/'translated' string fields in instance attrs
    * --add is_visible boolean for AOs
    For instance consistency - not yet supported.
    * --only set instance vals if not default config vals; clean up JSON write
    Configuration now supports not writing initialization/default fields to JSON.
    * --Add access to user_defined view and setter
    * --better names for object init attrs and object instance  init attrs
    * --use base obj's current state to build ObjectInstanceAttr and obj copy
    * --only change fields if they are different than defaults.
    jturner65 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a535d57 View commit details
    Browse the repository at this point in the history
  4. --[BE] - Baselink ID init via constant (#2465)

    * --system-wide constant for baseLink ID
    * --use BASELINK_ID instead of magic number -1 to denote baseLink
    * --Use ID_UNDEFINED for rigid object link ids.
    * --more fixes
    jturner65 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e1d9880 View commit details
    Browse the repository at this point in the history
  5. --[BE] - ManagedContainer updates and cleanups (#2475)

    * --clean up handle query
    * --move object library map settings to base class.
    * --make managed container map member variables private.
    * --verify templated accessor results are cast to legitimate type.
    * --simplify caller-message arguments
    * --clarify naming of existing dirty flag, in preparation of file-save-based flag.
    * --move filepath check flag to base attributes to make available
    * --treat pbr/ibl helper key as hidden field
    * --provide rudiments of file-status dirty flags.
    The purpose of this flag is to specify that a particular Managed File-based object has been registered in its Manager in a state that is different than that of its disk-based counterpart.
    * --rename constructor-building method for clarity
    jturner65 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a24e13f View commit details
    Browse the repository at this point in the history
  6. --[Bugfix] - Compare Configuration scalar doubles properly (#2478)

    * --remove unnecessary magnum decorator
    * --add and test support for scalar ConfigValues requiring fuzzy compare
    This uses the same mechanism that Magnum constructs use, so results are consistent
    * --separate Configuration fuzzy compare tests; minor updates
    * --make sure comparisons only involve the number of non-hidden values
    There is a possibility, albeit remote, that 2 otherwise identical configurations might have a different number of internal-use/hidden values and would appear to be different when they were, in fact, the same. Not anymore. Note, these are only accessible internally (in c++ source) and so the likelihood of this happening is vanishingly small.
    jturner65 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2d09449 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    a6e0917 View commit details
    Browse the repository at this point in the history