-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port polish items from old HITL study branch #1671
Port polish items from old HITL study branch #1671
Conversation
a49fecf
to
f011755
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress! Let's see if we can simplify tutorial command line args, see comment below. Also, is there a plan to address #1 and #3 from the Asana item, perhaps a separate PR?
examples/siro_sandbox/sandbox_app.py
Outdated
@@ -710,6 +718,12 @@ def _parse_debug_third_person(args, framebuffer_size): | |||
default=False, | |||
help="Shows an intro sequence that helps familiarize the user to the scene and task in a HITL context.", | |||
) | |||
parser.add_argument( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked @rutadesai on Slack about if we can just make this the only option for the tutorial (and thus we don't need to complicate the code with multiple tutorial-related command-line args).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
if end_pos[1] != rigid_state.translation[1]: | ||
|
||
# try_step may fail, in which case it simply returns the start argument | ||
did_try_step_fail = end_pos == rigid_state.translation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is fine. But going forward, let's keep our PRs into the HITL codebase separate from our PRs into Habitat-lab/baselines.
@eundersander these items are already addressed. See my Asana task comment. |
f011755
to
a901471
Compare
1fa1526
to
b893fc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
511df01
into
eundersander/SIRo_hitl_Sep5_demo_refactored
Motivation and Context
Port polish items from old HITL study branch. See this Asana task (and comments) for more context.
How Has This Been Tested
Running sandbox app locally on MacBook Pro 2021.
Assets and habitat-sim setup the same as in this SIRo Sandbox snapshot.
Launch command (--show-tutorial flag added):
Note, this is not tested with rearrange app state, since it is not working on demo branch.
Types of changes
eundersander/SIRo_hitl_Sep5_demo_refactored
(demo branch).