-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Spot-floating bug #1661
Fix Spot-floating bug #1661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
# Offset the base | ||
end_pos -= self.cur_articulated_agent.params.base_offset | ||
# Offset the base if the base height is different between end_pos and the current state | ||
if end_pos[1] != rigid_state.translation[1]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this in a scene with different floor heights? At a glance, it's not really intuitive why this fix is necessary or correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks Ruslan and Eric!
* Using cleaner Spot-floating bug fix (#1661) * fix spot floating bug * Ruta's rearrange study progress_str changes * Ruta's shorter tutorial changes * keepping only short tutorial version * enable tutorial for the AppStateSocialNavStudy * delete file added after rebase
* fix spot floating bug
* fix spot floating bug
Motivation and Context
Fix Spot-floating bug (see video attached). For more context see this Asana task.
Screen.Recording.2023-10-31.at.16.02.31.mov
How Has This Been Tested
Running HITL tool locally on MacBook Pro 2021.
python examples/siro_sandbox/sandbox_app.py \ --disable-inverse-kinematics \ --never-end \ --gui-controlled-agent-index 1 \ --app-state rearrange \ --cfg social_rearrange/pop_play.yaml \ --cfg-opts \ habitat.environment.iterator_options.cycle=False \ habitat_baselines.evaluate=True \ habitat_baselines.num_environments=1 \ habitat_baselines.eval.should_load_ckpt=False \ habitat_baselines.rl.agent.num_pool_agents_per_type='[1,1]' \ habitat.simulator.habitat_sim_v0.allow_sliding=False
Types of changes
Checklist