Add GCS dependencies to resolve_dependency and refactor cmake modules

[tigrux]

The goal of this change is to refactor and simplify the existing cmake modules.

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	9f99aec
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/665e4cefc5f3a400085bd381

[assignUser]

I see that it works with the current protobuf version, that's nice.

I think updating the cmake version is great OVERRIDE_FINDE_PACKAGE is really useful. I am not sure what we gain from EXCLUDE_FROM_ALL though?

Any time resolve_dependencies get's called for any of these they will be needed as a dependency for other target's so they will get build?

[assignUser]

Once #9861 is merged you can remove the install bits in the workflows and rebase on it (you'll have to wait a bit after the merge for the rebuild of the containers). I'll review after that but looks good so far, thanks for the contribution! :)

[tigrux]

Hello @majetideepak, @assignUser, @kgpai, @pedroerp, @bdice.
As agreed, here is the second part of the change to update to cmake 3.28.
This one uses the cmake support previously added to refactor the cmake modules.

[assignUser]

Looks good thanks! As the docker images have been updated you can remove the steps where you installed the recent cmake in #9861.

[assignUser]

Once CI turns green this should be ready to merge.

[bdice]

This looks good from what I can tell.

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kgpai merged this pull request in c50a117.