Skip to content

Remove redundant cmake==3.28.3 installs#9976

Closed
majetideepak wants to merge 1 commit intofacebookincubator:mainfrom
majetideepak:clean-cmake
Closed

Remove redundant cmake==3.28.3 installs#9976
majetideepak wants to merge 1 commit intofacebookincubator:mainfrom
majetideepak:clean-cmake

Conversation

@majetideepak
Copy link
Copy Markdown
Collaborator

@majetideepak majetideepak commented May 30, 2024

The CI image has this cmake version installed.

@netlify
Copy link
Copy Markdown

netlify bot commented May 30, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 710cfe5
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6657d8720e64520007ee969b

@majetideepak majetideepak requested a review from assignUser May 30, 2024 01:55
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2024
Copy link
Copy Markdown
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh good catch, I thought we removed that in #9072 maybe that committ wasn't imported 🤷 edit: oh it's just not merged yet 😁

@majetideepak
Copy link
Copy Markdown
Collaborator Author

I thought this was left over from that PR as well :). Closing this in favor of #9072

@majetideepak majetideepak deleted the clean-cmake branch June 21, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants