refactor: Revert iceberg data file statistics changes#16999
Closed
nmahadevuni wants to merge 2 commits intofacebookincubator:mainfrom
Closed
refactor: Revert iceberg data file statistics changes#16999nmahadevuni wants to merge 2 commits intofacebookincubator:mainfrom
nmahadevuni wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
nmahadevuni
changed the title
nmahadevuni
force-pushed
the
revert_iceberg_stats
branch
from
eba3fde to
4f68530
Compare
Build Impact AnalysisSelective Build Targets (building these covers all 287 affected)Total affected: 287/556 targets
Affected targets (287)Directly changed (120)
Transitively affected (167)
Slow path • Graph generated from PR branch |
…er (facebookincubator#16867)" This reverts commit e154cab.
This reverts commit e7dd656.
nmahadevuni
force-pushed
the
revert_iceberg_stats
branch
from
4f68530 to
c786f67
Compare
aditi-pandit
approved these changes
Apr 1, 2026
Collaborator
aditi-pandit
left a comment
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @nmahadevuni
Collaborator
|
@amitkdutta : We should submit this for the Iceberg issues in advancing Velox. Can you help merge ? |
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this in D99206279. |
bikramSingh91
added
the
ready-to-merge
Collaborator
|
@nmahadevuni What is the root cause of the issuehttps://github.com/prestodb/presto/issues/27450? |
Collaborator
Author
@PingLiuPing Since the basic operations on Iceberg tables are affected, we chose to revert it. |
czentgr
approved these changes
Apr 2, 2026
Contributor
|
FYI folks, this may take some time. It appears the original API change impacted a number of internal projects and required significant effort to address (thanks to @kgpai). I’ll need to roll back those changes, but given additional code that has landed since the original change, the rollback can be a bit tricky. I'll post an update if it goes past monday next week. |
|
@bikramSingh91 merged this pull request in 303bba6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prestodb/presto#27450. The Native Iceberg test failures [TestCreateTable and TestMetadata suite] reported and disabled after advancing velox in prestodb/presto#27390 have been traced to Iceberg data file statistics collection changes. Reverting them.