Skip to content

fix(build): IcebergParquetStatsCollector requires ParquetWriter#16867

Closed
czentgr wants to merge 1 commit intofacebookincubator:mainfrom
czentgr:cz_fix_iceberg_symbols
Closed

fix(build): IcebergParquetStatsCollector requires ParquetWriter#16867
czentgr wants to merge 1 commit intofacebookincubator:mainfrom
czentgr:cz_fix_iceberg_symbols

Conversation

@czentgr
Copy link
Copy Markdown
Collaborator

@czentgr czentgr commented Mar 20, 2026

Also cleaned up some of the headers where duplicate inclusion was made and moved some from the header file to the cpp file.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2026

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 6f52cdc
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/69c1bb2bac8299000813bac9

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2026
@czentgr czentgr marked this pull request as ready for review March 20, 2026 23:17
@czentgr czentgr requested a review from majetideepak as a code owner March 20, 2026 23:17
@czentgr czentgr changed the title fix(build): IcebergStatsCollector requires ParquetWriter fix(build): IcebergParquetStatsCollector requires ParquetWriter Mar 20, 2026
@czentgr czentgr force-pushed the cz_fix_iceberg_symbols branch from ac3fb59 to f23f6e4 Compare March 20, 2026 23:18
Copy link
Copy Markdown
Collaborator

@PingLiuPing PingLiuPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@czentgr czentgr force-pushed the cz_fix_iceberg_symbols branch from f23f6e4 to 98df58f Compare March 21, 2026 22:37
Copy link
Copy Markdown
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @czentgr

Copy link
Copy Markdown
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @czentgr

@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Mar 23, 2026

@kgpai has imported this pull request. If you are a Meta employee, you can view this in D97778499.

Also cleaned up some of the headers where duplicate
inclusion was made and moved some from the header file
to the cpp file.
@czentgr czentgr force-pushed the cz_fix_iceberg_symbols branch from 98df58f to 6f52cdc Compare March 23, 2026 22:14
@meta-codesync meta-codesync bot closed this in e154cab Mar 24, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Mar 24, 2026

@kgpai merged this pull request in e154cab.

nmahadevuni added a commit to nmahadevuni/velox that referenced this pull request Apr 1, 2026
nmahadevuni added a commit to nmahadevuni/velox that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants