build(cudf): Update cudf dependency to 26.02#15937
Closed
bdice wants to merge 3 commits intofacebookincubator:mainfrom
Closed
build(cudf): Update cudf dependency to 26.02#15937bdice wants to merge 3 commits intofacebookincubator:mainfrom
bdice wants to merge 3 commits intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
bdice
changed the title
majetideepak
approved these changes
Jan 12, 2026
majetideepak
added
the
ready-to-merge
Collaborator
|
@bdice what is the minimum GCC version required for cudf 26.02? Can we add a check for this version? |
kevinwilfong
removed
the
ready-to-merge
Contributor
|
@majetideepak since you added a comment after accepting, I'm going to remove the ready-to-merge tag, if it's addressed or you didn't intend it to block landing please feel free to add it back |
Collaborator
Author
|
The minimum GCC version isn't changing -- still 13.3. I'll open a separate PR with that build-time check. |
Collaborator
Author
|
@majetideepak @kevinwilfong I opened this PR with a CMake check for cuDF GCC version. #15986 Since this PR didn't change the compiler requirements, I think it should be safe to merge as-is. |
majetideepak
added
the
ready-to-merge
Collaborator
|
@kevinwilfong This PR can land as-is, as @bdice mentioned. |
bdice
changed the title
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this in D90518369. |
|
@kevinwilfong merged this pull request in 2cf3756. |
3 tasks
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…16026) Summary: Updates the expected hash values in `CudfFilterProjectTest.hashWithSeed` and `CudfFilterProjectTest.hashWithSeedMultiColumns` tests to match the new output from cudf 26.02. ## Problem After the cudf dependency was upgraded from 25.12 to 26.02 in commit 2cf3756 (#15937), the `velox_cudf_spark_filter_project_test` started failing: [ FAILED ] CudfFilterProjectTest.hashWithSeed [ FAILED ] CudfFilterProjectTest.hashWithSeedMultiColumns The `cudf::hashing::murmurhash3_x86_32()` function now produces different hash values for the same inputs, causing the hardcoded expected values in the tests to no longer match. ## Root Cause The cudf 26.02 upgrade changed the behavior of the MurmurHash3 x86 32-bit hash function. This is likely an intentional change or bug fix in the upstream cudf library. ## Changes Updated the expected hash values in `FilterProjectTest.cpp`: | Test | Index | Old Value | New Value | |------|-------|-----------|-----------| | `hashWithSeed` | 0 | 1049813396 | -1604625029 | | `hashWithSeed` | 1 | 1800792340 | -853646085 | | `hashWithSeedMultiColumns` | 0 | -864217843 | -572895191 | | `hashWithSeedMultiColumns` | 1 | 821064941 | 724095561 | ## Testing - [x] `velox_cudf_spark_filter_project_test` passes with updated values ## Checklist - [x] Tests pass locally - [x] No new warnings introduced Pull Request resolved: #16026 Reviewed By: mbasmanova Differential Revision: D91045880 Pulled By: kgpai fbshipit-source-id: 1b05a687907ce39844f04413ceb7be6786e29669
karthikeyann
pushed a commit
to karthikeyann/velox
that referenced
this pull request
Jan 24, 2026
…acebookincubator#16026) Summary: Updates the expected hash values in `CudfFilterProjectTest.hashWithSeed` and `CudfFilterProjectTest.hashWithSeedMultiColumns` tests to match the new output from cudf 26.02. ## Problem After the cudf dependency was upgraded from 25.12 to 26.02 in commit 2cf3756 (facebookincubator#15937), the `velox_cudf_spark_filter_project_test` started failing: [ FAILED ] CudfFilterProjectTest.hashWithSeed [ FAILED ] CudfFilterProjectTest.hashWithSeedMultiColumns The `cudf::hashing::murmurhash3_x86_32()` function now produces different hash values for the same inputs, causing the hardcoded expected values in the tests to no longer match. ## Root Cause The cudf 26.02 upgrade changed the behavior of the MurmurHash3 x86 32-bit hash function. This is likely an intentional change or bug fix in the upstream cudf library. ## Changes Updated the expected hash values in `FilterProjectTest.cpp`: | Test | Index | Old Value | New Value | |------|-------|-----------|-----------| | `hashWithSeed` | 0 | 1049813396 | -1604625029 | | `hashWithSeed` | 1 | 1800792340 | -853646085 | | `hashWithSeedMultiColumns` | 0 | -864217843 | -572895191 | | `hashWithSeedMultiColumns` | 1 | 821064941 | 724095561 | ## Testing - [x] `velox_cudf_spark_filter_project_test` passes with updated values ## Checklist - [x] Tests pass locally - [x] No new warnings introduced Pull Request resolved: facebookincubator#16026 Reviewed By: mbasmanova Differential Revision: D91045880 Pulled By: kgpai fbshipit-source-id: 1b05a687907ce39844f04413ceb7be6786e29669
karthikeyann
pushed a commit
to karthikeyann/velox
that referenced
this pull request
Jan 24, 2026
Summary: Updates cudf to a prerelease of version 26.02. This is needed to get some fixes like rapidsai/cudf#20834. We may also need rapidsai/cudf#20982 -- I will see if CI passes first, and update again if needed. Pull Request resolved: facebookincubator#15937 Reviewed By: pratikpugalia Differential Revision: D90518369 Pulled By: kevinwilfong fbshipit-source-id: 624d17c1ecca1f360e7dbaa1e097776cb48d2616
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
Summary: This PR pins cuDF's dependencies: rapids-cmake, rmm, and kvikio. This is a follow-up to #15937, which updates the cuDF dependency to 26.02. It pulls a recent cuDF commit from `main`. However, cuDF's core RAPIDS dependencies (rapids-cmake, RMM, KvikIO) are currently unpinned, meaning that they will continue to pull the latest from `main` while cuDF remains pinned. We would like to ensure that builds are stable and reproducible, which means we should pin these core cuDF dependencies. To make future updates simpler, I added a script `scripts/update-cudf-deps.sh`. To update to a recent branch, developers can run: ```bash ./scripts/update-cudf-deps.sh --branch main ./scripts/update-cudf-deps.sh --branch release/26.02 ``` A pain point that cuDF developers have faced is testing Velox with cuDF pull requests in progress. To support that use case, developers can run: ```bash ./scripts/update-cudf-deps.sh --pr <pr-number> ``` To use a specific cuDF commit with compatible dependency versions, developers can run: ```bash ./scripts/update-cudf-deps.sh --commit <sha> ``` This automatically finds compatible rapids-cmake, rmm, and kvikio versions by selecting the most recent main branch commit before the specified cuDF commit date, ensuring all dependencies are temporally compatible. Pull Request resolved: #15992 Reviewed By: kgpai Differential Revision: D91639452 Pulled By: kagamiori fbshipit-source-id: f9867713cae9357bc23dd9a4f6004151fac6b622
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates cudf to a prerelease of version 26.02. This is needed to get some fixes like rapidsai/cudf#20834. We may also need rapidsai/cudf#20982 -- I will see if CI passes first, and update again if needed.