fix(cudf): Update hash_with_seed test expected values for cudf 26.02#16026
fix(cudf): Update hash_with_seed test expected values for cudf 26.02#16026Avinash-Raj wants to merge 3 commits intofacebookincubator:mainfrom
Conversation
Avinash-Raj
requested review from
bdice,
devavret,
karthikeyann and
mhaseeb123
as code owners
|
Hi @Avinash-Raj! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for meta-velox canceled.
|
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Thanks! Yes, this was an intentional change.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
bot
added
the
CLA Signed
karthikeyann
added
the
ready-to-merge
…acebookincubator#16026) Summary: Updates the expected hash values in `CudfFilterProjectTest.hashWithSeed` and `CudfFilterProjectTest.hashWithSeedMultiColumns` tests to match the new output from cudf 26.02. ## Problem After the cudf dependency was upgraded from 25.12 to 26.02 in commit 2cf3756 (facebookincubator#15937), the `velox_cudf_spark_filter_project_test` started failing: [ FAILED ] CudfFilterProjectTest.hashWithSeed [ FAILED ] CudfFilterProjectTest.hashWithSeedMultiColumns The `cudf::hashing::murmurhash3_x86_32()` function now produces different hash values for the same inputs, causing the hardcoded expected values in the tests to no longer match. ## Root Cause The cudf 26.02 upgrade changed the behavior of the MurmurHash3 x86 32-bit hash function. This is likely an intentional change or bug fix in the upstream cudf library. ## Changes Updated the expected hash values in `FilterProjectTest.cpp`: | Test | Index | Old Value | New Value | |------|-------|-----------|-----------| | `hashWithSeed` | 0 | 1049813396 | -1604625029 | | `hashWithSeed` | 1 | 1800792340 | -853646085 | | `hashWithSeedMultiColumns` | 0 | -864217843 | -572895191 | | `hashWithSeedMultiColumns` | 1 | 821064941 | 724095561 | ## Testing - [x] `velox_cudf_spark_filter_project_test` passes with updated values ## Checklist - [x] Tests pass locally - [x] No new warnings introduced Pull Request resolved: facebookincubator#16026 Reviewed By: mbasmanova Differential Revision: D91045880 Pulled By: kgpai fbshipit-source-id: 1b05a687907ce39844f04413ceb7be6786e29669
5 participants
Summary
Updates the expected hash values in
CudfFilterProjectTest.hashWithSeedandCudfFilterProjectTest.hashWithSeedMultiColumnstests to match the new output from cudf 26.02.Problem
After the cudf dependency was upgraded from 25.12 to 26.02 in commit 2cf3756 (#15937), the
velox_cudf_spark_filter_project_teststarted failing:[ FAILED ] CudfFilterProjectTest.hashWithSeed
[ FAILED ] CudfFilterProjectTest.hashWithSeedMultiColumns
The
cudf::hashing::murmurhash3_x86_32()function now produces different hash values for the same inputs, causing the hardcoded expected values in the tests to no longer match.Root Cause
The cudf 26.02 upgrade changed the behavior of the MurmurHash3 x86 32-bit hash function. This is likely an intentional change or bug fix in the upstream cudf library.
Changes
Updated the expected hash values in
FilterProjectTest.cpp:hashWithSeedhashWithSeedhashWithSeedMultiColumnshashWithSeedMultiColumnsTesting
velox_cudf_spark_filter_project_testpasses with updated valuesChecklist