build(cudf): Require GCC >= 13.3 for cuDF builds#15986
Closed
bdice wants to merge 2 commits intofacebookincubator:mainfrom
Closed
build(cudf): Require GCC >= 13.3 for cuDF builds#15986bdice wants to merge 2 commits intofacebookincubator:mainfrom
bdice wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
added
the
ready-to-merge
karthikeyann
approved these changes
Jan 12, 2026
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this in D90518541. |
|
@kevinwilfong merged this pull request in 6218c09. |
7 tasks
czentgr
added a commit
to prestodb/presto
that referenced
this pull request
Jan 15, 2026
Velox PR github.com/facebookincubator/velox/pull/15986 introduces a check on the compiler version. The dependency image ships with gcc12, gcc14 and clang21 but only builds with gcc12. If the GPU support is enabled (PRESTO_ENABLE_CUDF) the build will fail. This PR adds a check if this config is used and switches to gcc14 if this is the case. ## Description <!---Describe your changes in detail--> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
karthikeyann
pushed a commit
to karthikeyann/velox
that referenced
this pull request
Jan 24, 2026
…5986) Summary: - Adds a compiler check when `VELOX_ENABLE_CUDF` is enabled - Fails with a fatal error if the compiler is not GCC - Fails with a fatal error if GCC version is less than 13.3 Pull Request resolved: facebookincubator#15986 Reviewed By: peterenescu Differential Revision: D90518541 Pulled By: kevinwilfong fbshipit-source-id: 485f31bbb2d913ee1a70c4e7dc9683de1b6f7b8c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VELOX_ENABLE_CUDFis enabled