Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external dir #645

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

jesswong
Copy link
Contributor

@jesswong jesswong commented Dec 4, 2024

I missed removing the external dir which had a reference to the mpark-wg21 submodule so was breaking the git fetch configuration in a cmake file

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2024
@jesswong jesswong requested a review from ispeters December 4, 2024 18:13
jesswong referenced this pull request Dec 4, 2024
* Remove .gitmodules

* Remove doc/std
@jesswong jesswong merged commit 1dd0208 into facebookexperimental:main Dec 4, 2024
53 checks passed
@jesswong jesswong deleted the cleanup branch December 4, 2024 18:37
jesswong added a commit to jesswong/libunifex that referenced this pull request Dec 4, 2024
jesswong added a commit that referenced this pull request Dec 4, 2024
* Add threadid to AsyncStackRoot

* Add syscall.h

* fix build

* add unistd.h

* Add processthreadsapi.h

* Add windows.h

* address comments

* address comments

* fix build

* move threadid to AsyncStackRootHolder

* run files through clang-format

* reduce the number of ifdefs

* Remove external dir (#645)

* remove utils namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants