Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .gitmodules and doc/std #643

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Remove .gitmodules and doc/std #643

merged 2 commits into from
Nov 26, 2024

Conversation

jesswong
Copy link
Contributor

@jesswong jesswong commented Nov 26, 2024 •
edited
Loading

This diff removes .gitmodules since libunifex is no longer associated with wg21 and does not require the wg21 submodule or the draft papers. This will make syncing libunifex easier

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 26, 2024
ispeters
ispeters approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any references to the now-deleted submodule that need cleaning up, too? Maybe a Makefile that generates papers from source, or something? If so, those should go, too, but otherwise this looks good.

@jesswong jesswong changed the title Remove .gitmodules Remove .gitmodules and doc/std Nov 26, 2024
@jesswong
Copy link
Contributor Author

Are there any references to the now-deleted submodule that need cleaning up, too? Maybe a Makefile that generates papers from source, or something? If so, those should go, too, but otherwise this looks good.

In doc/std there was a makefile that references the submodule. I just removed the whole dir since it also included some other draft papers that Eric and Lewis were working on.

@jesswong jesswong merged commit 256bb4a into facebookexperimental:main Nov 26, 2024
53 checks passed
@jesswong jesswong deleted the cleanup branch November 26, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ispeters ispeters ispeters approved these changes

@janondrusek janondrusek Awaiting requested review from janondrusek

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesswong @ispeters @facebook-github-bot