Skip to content

Commit

Permalink
Remove .gitmodules and doc/std (#643)
Browse files Browse the repository at this point in the history 
* Remove .gitmodules

* Remove doc/std
  • Loading branch information
@jesswong
jesswong authored Nov 26, 2024
1 parent ef9db15 commit 256bb4a
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 4,854 deletions.
3 changes: 0 additions & 3 deletions .gitmodules
View file

This file was deleted.

Loading

2 comments on commit 256bb4a

@narslan
Copy link

@narslan narslan commented on 256bb4a Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jesswong ,
After this commit, If I want to use libunifex as in the following CMake file, git fetch would fail, because of the git sub-module under external.

include(FetchContent)

FetchContent_Declare(
    libunifex
    GIT_REPOSITORY https://github.com/facebookexperimental/libunifex.git
    GIT_TAG main
     
)
FetchContent_MakeAvailable(libunifex)

Using the tag, I can go to the previous commit though.

...
 GIT_TAG ef9db15be6464c4d207d625b809da477aed2ff74
...

@jesswong
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks for letting me know! i have a PR up to remove the external dir: #645

Please sign in to comment.