Restore dropped #include directives in fsevents.cpp#1300
Closed
carlocab wants to merge 1 commit intofacebook:mainfrom
Closed
Restore dropped #include directives in fsevents.cpp#1300carlocab wants to merge 1 commit intofacebook:mainfrom
#include directives in fsevents.cpp#1300carlocab wants to merge 1 commit intofacebook:mainfrom
Conversation
These were incorrectly dropped in 376b9ae. Fixes facebook#1298. Co-authored-by: Felipe Santos <felipemillhouse@gmail.com>
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D80720992. (Because this pull request was imported automatically, there will not be any future comments.) |
carlocab
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Aug 21, 2025
See facebook/watchman#1298. Upstreamed at facebook/watchman#1300. Closes #234268.
6 tasks
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Aug 25, 2025
Summary: These were incorrectly dropped in 376b9aeab18d75287f7f100313093f99d0b7a82a. Fixes facebook/watchman#1298. X-link: facebook/watchman#1300 Reviewed By: genevievehelsel Differential Revision: D80720992 fbshipit-source-id: 2254e51fb80a646f1d01816cd7e0f502e9f8227d Co-authored-by: Felipe Santos <felipemillhouse@gmail.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
Summary: To avoid these getting removed incorrectly again, move the `#if HAVE_FSEVENTS` to the top of the file see: #1300 / D80720992 See also D78732293 Differential Revision: D80902289 fbshipit-source-id: eb32e804cfa620f1fa91f4e764679e787917e36c
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Aug 25, 2025
Summary: To avoid these getting removed incorrectly again, move the `#if HAVE_FSEVENTS` to the top of the file see: facebook/watchman#1300 / D80720992 See also D78732293 Differential Revision: D80902289 fbshipit-source-id: eb32e804cfa620f1fa91f4e764679e787917e36c
Contributor
|
This pull request has been merged in 3d5a447. |
Contributor
Contributor
Author
|
Thanks @genevievehelsel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were incorrectly dropped in 376b9ae.
Fixes #1298.
Co-authored-by: Felipe Santos felipemillhouse@gmail.com