Skip to content

Revert watchman 2025.08.18.00 (and dependencies)#234268

Closed
clint-stripe wants to merge 1 commit intoHomebrew:mainfrom
clint-stripe:clint/revert-broken-watchman
Closed

Revert watchman 2025.08.18.00 (and dependencies)#234268
clint-stripe wants to merge 1 commit intoHomebrew:mainfrom
clint-stripe:clint/revert-broken-watchman

Conversation

@clint-stripe
Copy link

@clint-stripe clint-stripe commented Aug 20, 2025

This reverts commit 7ebb3ff, reversing changes made to 4d98891.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This reverts #233972 as this version is significantly broken: facebook/watchman#1298

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 20, 2025
@github-actions
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@clint-stripe
Copy link
Author

We have a significant number of engineers blocked by this, and this is a simple git revert -m 1 7ebb3ff790a647055949e5f4662cc45228d17bb8.

Is it strictly necessary to let the bot handle the formula updates?

@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@SMillerDev
Copy link
Member

Is it strictly necessary to let the bot handle the formula updates?

Yes, otherwise there is no update.

@SMillerDev SMillerDev added the CI-version-downgrade Pass --skip-stable-version-audit to brew test-bot. label Aug 21, 2025
@github-actions
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

…mon-2025.08.18.00"

This reverts commit 7ebb3ff, reversing
changes made to 4d98891.
@clint-stripe clint-stripe force-pushed the clint/revert-broken-watchman branch from 22143be to f465a5d Compare August 21, 2025 08:13
@clint-stripe
Copy link
Author

Is it strictly necessary to let the bot handle the formula updates?

Yes, otherwise there is no update.

I'm not sure I follow still, but easy enough to do :) this is a revert to the previous version, what is being updated? (Is there some documentation on how to properly do a revert? As mentioned, this is a pretty badly broken change and I seem to have tripped a bunch of linters doing the normal git operations here.)

@carlocab
Copy link
Member

This should probably be fixed forward, otherwise we'll probably just have the same problem again next week.

The issue seems unlikely to be in Watchman, since there don't seem to be any substantial code changes in between versions: facebook/watchman@v2025.08.11.00...v2025.08.18.00

@carlocab carlocab added the maintainer feedback Additional maintainers' opinions may be needed label Aug 21, 2025
@FelipeSSantos1
Copy link

the fix looks simple: facebook/watchman#1298 (comment)

@carlocab
Copy link
Member

Thanks for tracking that down, @FelipeSSantos1.

I've opened #234392 to apply the fix to the formula.

@carlocab carlocab marked this pull request as draft August 21, 2025 17:48
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Aug 21, 2025
@FelipeSSantos1
Copy link

Thank you @carlocab for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-version-downgrade Pass --skip-stable-version-audit to brew test-bot. maintainer feedback Additional maintainers' opinions may be needed superseded PR was replaced by another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants