Revert watchman 2025.08.18.00 (and dependencies)#234268
Revert watchman 2025.08.18.00 (and dependencies)#234268clint-stripe wants to merge 1 commit intoHomebrew:mainfrom
Conversation
|
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
|
We have a significant number of engineers blocked by this, and this is a simple Is it strictly necessary to let the bot handle the formula updates? |
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
Yes, otherwise there is no update. |
|
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
22143be to
f465a5d
Compare
I'm not sure I follow still, but easy enough to do :) this is a revert to the previous version, what is being updated? (Is there some documentation on how to properly do a revert? As mentioned, this is a pretty badly broken change and I seem to have tripped a bunch of linters doing the normal git operations here.) |
|
This should probably be fixed forward, otherwise we'll probably just have the same problem again next week. The issue seems unlikely to be in Watchman, since there don't seem to be any substantial code changes in between versions: facebook/watchman@v2025.08.11.00...v2025.08.18.00 |
|
the fix looks simple: facebook/watchman#1298 (comment) |
See facebook/watchman#1298. Upstreamed at facebook/watchman#1300. Closes #234268.
|
Thanks for tracking that down, @FelipeSSantos1. I've opened #234392 to apply the fix to the formula. |
|
Thank you @carlocab for the quick fix |
This reverts commit 7ebb3ff, reversing changes made to 4d98891.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This reverts #233972 as this version is significantly broken: facebook/watchman#1298