edencommon fb303 fbthrift fizz folly mvfst wangle watchman 2025.08.25.00#234889
Merged
BrewTestBot merged 17 commits intomainfrom Aug 26, 2025
Merged
edencommon fb303 fbthrift fizz folly mvfst wangle watchman 2025.08.25.00#234889BrewTestBot merged 17 commits intomainfrom
BrewTestBot merged 17 commits intomainfrom
Conversation
chenrui333
approved these changes
Aug 25, 2025
4759abd to
21b4268
Compare
carlocab
approved these changes
Aug 25, 2025
Member
|
Patch at facebook/proxygen#570 needs rebasing. CC @cho-m |
carlocab
reviewed
Aug 25, 2025
0639a17 to
3595da5
Compare
Member
|
Member
|
Let's drop Proxygen for now. I suspect the object file for |
watchman: remove build patch Signed-off-by: Rui Chen <rui@chenrui.dev>
3595da5 to
935c8e6
Compare
Member
|
Proxygen probably just needs something like diff --git i/proxygen/lib/CMakeLists.txt w/proxygen/lib/CMakeLists.txt
index fef0c98..ce1b293 100644
--- i/proxygen/lib/CMakeLists.txt
+++ w/proxygen/lib/CMakeLists.txt
@@ -105,6 +105,7 @@ set(
# append proxygen::coro sources
set(
PROXYGEN_CORO_SOURCES
+ dns/CachingDNSResolver.cpp
dns/DNSModule.cpp
dns/DNSResolver.cpp
dns/Rfc6724.cppMight be missing other files too. |
This week's build doesn't work.
935c8e6 to
1714f2c
Compare
Member
|
I'll follow-up on |
Contributor
|
Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.folly
Details
release notes
View the full release notes at https://github.com/facebook/folly/releases/tag/v2025.08.25.00.
wangle
release notes
View the full release notes at https://github.com/facebook/wangle/releases/tag/v2025.08.25.00.