[DevTools] Allow inspecting root when navigating Suspense timeline #34380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps identifying what suspended the shell. We should probably add more affordances to inspect the root in other places since whatever is suspending the shell is responsible for first-contentful-paint.
github-actions
bot
added
the
React Core Team
sebmarkbage
reviewed
Sep 4, 2025
| if (current !== suspense) { | ||
| suspenseTreeList.push(current); | ||
| } | ||
| // Include the root even if we won't suspend it. |
Collaborator
There was a problem hiding this comment.
What does "even if we won't suspend it" mean here?
Seems important to start dealing with the hasUniqueSuspenders case ASAP because for all these cases I'm wondering what your intention is.
Collaborator
Author
There was a problem hiding this comment.
Meaning that the backend doesn't support suspending the root because there isn't anything meaningful to display other than showing a blank.
sebmarkbage
approved these changes
Sep 4, 2025
eps1lon
deleted the
sebbie/09-04-_devtools_allow_inspecting_root_when_navigating_suspense_timeline
branch
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 4, 2025
github-actions bot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Sep 4, 2025
github-actions bot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps identifying what suspended the shell like in #34381
We should probably add more affordances to inspect the root in other places since whatever is suspending the shell is responsible for first-contentful-paint.