Skip to content

[DevTools] Allow inspecting root when navigating Suspense timeline #34380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 1 commit into from
Sep 4, 2025
+4 −5
Merged

[DevTools] Allow inspecting root when navigating Suspense timeline #34380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTimeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,9 @@ function getSuspendableDocumentOrderSuspense(
if (current === undefined) {
continue;
}
// Don't include the root. It's currently not supported to suspend the shell.
if (current !== suspense) {
suspenseTreeList.push(current);
}
// Include the root even if we won't suspend it.
Copy link
Collaborator

@sebmarkbage sebmarkbage Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "even if we won't suspend it" mean here?

Seems important to start dealing with the hasUniqueSuspenders case ASAP because for all these cases I'm wondering what your intention is.

Copy link
Collaborator Author

@eps1lon eps1lon Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaning that the backend doesn't support suspending the root because there isn't anything meaningful to display other than showing a blank.

// You should be able to see what suspended the shell.
suspenseTreeList.push(current);
// Add children in reverse order to maintain document order
for (let j = current.children.length - 1; j >= 0; j--) {
const childSuspense = store.getSuspenseByID(current.children[j]);
Expand Down Expand Up @@ -139,7 +138,7 @@ function SuspenseTimelineInput({rootID}: {rootID: Element['id'] | void}) {

const pendingValue = +event.currentTarget.value;
const suspendedSet = timeline
.slice(pendingValue + 1)
.slice(pendingValue)
.map(suspense => suspense.id);

bridge.send('overrideSuspenseMilestone', {
Expand Down
Loading