[DevTools] Don't suspend shell while retrieving original source for "open-in-editor" #34381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
Collaborator
|
I didn't notice this since I always run in the "Always Open Files in External Editor" mode which disables the button. 😏 Btw, I have a todo to actually just deprecate this button and eventually remove it. Since I feel like it's not worth existing separately from the However, as a teaching opportunity it's nice to teach people about the new option to always open in external first (which removes the button), or teach people to jump to source code and then use the "Open in Editor" button from there which is a pattern that always works. |
sebmarkbage
approved these changes
Sep 4, 2025
eps1lon
deleted the
sebbie/09-04-_devtools_don_t_suspend_shell_while_retrieving_original_source_for_open-in-editor_
branch
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in internal apps that inspecting an element took a while on the first click. I used the new Suspense tab to find what was suspending the shell :taps-head:
Before:
CleanShot.2025-09-04.at.13.52.03.mp4
After:
CleanShot.2025-09-04.at.14.04.56.mp4