[iOS] Remove outdated artifacts codegen early return #53690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
This comment was marked as outdated.
This comment was marked as outdated.
When no libraries are detected, artifacts codegen bails early, which breaks the build, since required podspecs aren't created.
kitten
force-pushed
the
@kitten/fix/react-native-libraries-autolinking
branch
from
e6a5d05 to
605869b
Compare
kitten
changed the title
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D82103491. |
This was referenced Sep 10, 2025
Closed
Closed
|
@cipolleschi merged this pull request in f6f5ea0. |
|
This pull request was successfully merged by @kitten in f6f5ea0 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
Summary: Follow-up to #53503 for a regression When no React Native module is present this bail condition stops us from generating the artifacts podspec that's needed to complete build. ## Changelog: [IOS] [FIXED] - Fix regression that skips artifacts code generation Pull Request resolved: #53690 Test Plan: - Create an app **without** any React Native modules, run `pod install`; without this fix the podspec will be missing and the build will fail - With expo this can be reproduced using `create-expo-app --template blank-typescript@next` on `[email protected]` - With the community CLI this can be reproduced using `npx react-native-community/cli@latest init test --skip-install --version 0.81.2` and uninstalling `react-native-safe-area-context` Reviewed By: javache Differential Revision: D82103491 Pulled By: cipolleschi fbshipit-source-id: 3d9619b5a935ca920220824b3963a9a107f926ca
|
This pull request was successfully merged by @kitten in c3149f2 When will my fix make it into a release? | How to file a pick request? |
vzaidman
pushed a commit
that referenced
this pull request
Sep 15, 2025
Summary: Follow-up to #53503 for a regression When no React Native module is present this bail condition stops us from generating the artifacts podspec that's needed to complete build. ## Changelog: [IOS] [FIXED] - Fix regression that skips artifacts code generation Pull Request resolved: #53690 Test Plan: - Create an app **without** any React Native modules, run `pod install`; without this fix the podspec will be missing and the build will fail - With expo this can be reproduced using `create-expo-app --template blank-typescript@next` on `[email protected]` - With the community CLI this can be reproduced using `npx react-native-community/cli@latest init test --skip-install --version 0.81.2` and uninstalling `react-native-safe-area-context` Reviewed By: javache Differential Revision: D82103491 Pulled By: cipolleschi fbshipit-source-id: 3d9619b5a935ca920220824b3963a9a107f926ca
|
This pull request was successfully merged by @kitten in 7754c05 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow-up to #53503 for a regression
When no React Native module is present this bail condition stops us from generating the artifacts podspec that's needed to complete build.
Changelog:
[IOS] [FIXED] - Fix regression that skips artifacts code generation
Test Plan:
pod install; without this fix the podspec will be missing and the build will failcreate-expo-app --template blank-typescript@nexton[email protected]npx @react-native-community/cli@latest init test --skip-install --version 0.81.2and uninstallingreact-native-safe-area-context