Skip to content

Commit f6f5ea0

Browse files
kittenfacebook-github-bot
authored andcommitted
Remove outdated artifacts codegen early return (#53690)
Summary: Follow-up to #53503 for a regression When no React Native module is present this bail condition stops us from generating the artifacts podspec that's needed to complete build. ## Changelog: [IOS] [FIXED] - Fix regression that skips artifacts code generation Pull Request resolved: #53690 Test Plan: - Create an app **without** any React Native modules, run `pod install`; without this fix the podspec will be missing and the build will fail - With expo this can be reproduced using `create-expo-app --template blank-typescript@next` on `[email protected]` - With the community CLI this can be reproduced using `npx react-native-community/cli@latest init test --skip-install --version 0.81.2` and uninstalling `react-native-safe-area-context` Reviewed By: javache Differential Revision: D82103491 Pulled By: cipolleschi fbshipit-source-id: 3d9619b5a935ca920220824b3963a9a107f926ca
1 parent 6c49572 commit f6f5ea0

File tree

1 file changed

+0
-5
lines changed
  • packages/react-native/scripts/codegen/generate-artifacts-executor

1 file changed

+0
-5
lines changed

packages/react-native/scripts/codegen/generate-artifacts-executor/index.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ function execute(
9999

100100
if (codegenEnabledLibraries.length === 0) {
101101
codegenLog('No codegen-enabled libraries found.', true);
102-
return;
103102
}
104103

105104
let platforms =
@@ -114,10 +113,6 @@ function execute(
114113
({name}) => !disabledLibraries.includes(name),
115114
);
116115

117-
if (!libraries.length) {
118-
continue;
119-
}
120-
121116
const outputPath = computeOutputPath(
122117
projectRoot,
123118
baseOutputPath,

0 commit comments

Comments
 (0)