[iOS] Use autolinking react-native-config output in iOS artifacts generator #53503

kitten · 2025-08-28T13:34:02Z

Summary:

Resolves #53501

This is a pretty major oversight of (presumably) the old autolinking refactor. The iOS autolinking's second stage, invoked in use_react_native! does not accept the react-native-config sub-command's react-native-config output. This is only invoked and used in the prior step, use_native_modules.

The second step instead invokes old code that does something similar to the new autolinking in scripts/generate-artifacts-executor, and happens to align in most cases. (But it does "autolinking" from scratch). tl;dr: When the results don't match up, things go wrong.

Instead, we now write the autolinking (react native config) results to a file, then read the output back in the second step.

This doesn't affect Android/Gradle, which are implemented correctly.

Changelog:

[IOS] [FIXED] - Use autolinking-generated react-native-config output in second step of cocoapods linking that generates artifacts and generated source

Test Plan:

See Codegen doesn't use autolinking on iOS #53501 for failing repro
Clone for working repro: https://github.com/byCedric/react-native-codegen-ios-autolinking/tree/fix-54503
- Note: Contains this PR's changes as a patch
- bun install
- bun expo run:ios

cipolleschi

code makes sense, but there is one important part that needs to be addressed.

packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js

kitten · 2025-08-28T22:19:58Z

I'm having some trouble building on main (hermes-engine isn't picking up a prebuilt for me, if that's what's supposed to happen and build fails w/o target for libhermes). I picked this change over to 0.81-stable, and rn-tester builds fine with and without these changes. I ran the legacy and turbo module tests and they completed as expected.

0.81-stable...kitten:react-native:@kitten/0.81-stable/fix/pick-broken-ios-autolinking

I'll have to look at the lint failures but the flow-bin isn't running for me and a version that's one minor behind isn't matching the flow check failures in the CI tests

packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js

cipolleschi

Talked at the CCS with @byCedric. I think this is good to go, as soon as the linting and JS tests are fixed.

kitten · 2025-09-02T08:10:19Z

Should be back to normal and passing. Rebased on main which also allowed me to check flow check manually. Main issues was console.warn -> codegenLog being needed, and an invalid FlowFixMe pragma on the require call

facebook-github-bot · 2025-09-02T14:02:46Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D81490755.

cortinico

Review automatically exported from Phabricator review in Meta.

react-native-bot · 2025-09-03T12:38:03Z

This pull request was successfully merged by @kitten in f170db4

^{When will my fix make it into a release? | How to file a pick request?}

facebook-github-bot · 2025-09-03T12:38:04Z

@cipolleschi merged this pull request in f170db4.

…#53503) Summary: Resolves #53501 This is a pretty major oversight of (presumably) the old autolinking refactor. The iOS autolinking's second stage, invoked in `use_react_native!` does not accept the `react-native-config` sub-command's `react-native-config` output. This is only invoked and used in the prior step, `use_native_modules`. The second step instead invokes old code that does something _similar_ to the new autolinking in `scripts/generate-artifacts-executor`, and happens to align in most cases. (But it does "autolinking" from scratch). tl;dr: When the results don't match up, things go wrong. Instead, we now write the autolinking (react native config) results to a file, then read the output back in the second step. This doesn't affect Android/Gradle, which are implemented correctly. ## Changelog: [IOS] [FIXED] - Use autolinking-generated react-native-config output in second step of cocoapods linking that generates artifacts and generated source Pull Request resolved: #53503 Test Plan: - See #53501 for failing repro - Clone for working repro: https://github.com/byCedric/react-native-codegen-ios-autolinking/tree/fix-54503 - Note: Contains this PR's changes as a patch - `bun install` - `bun expo run:ios` Reviewed By: cortinico Differential Revision: D81490755 Pulled By: cipolleschi fbshipit-source-id: eefe786a116404f4ed24bd7125dfb108a811f71e

…#53503) Summary: Resolves #53501 This is a pretty major oversight of (presumably) the old autolinking refactor. The iOS autolinking's second stage, invoked in `use_react_native!` does not accept the `react-native-config` sub-command's `react-native-config` output. This is only invoked and used in the prior step, `use_native_modules`. The second step instead invokes old code that does something _similar_ to the new autolinking in `scripts/generate-artifacts-executor`, and happens to align in most cases. (But it does "autolinking" from scratch). tl;dr: When the results don't match up, things go wrong. Instead, we now write the autolinking (react native config) results to a file, then read the output back in the second step. This doesn't affect Android/Gradle, which are implemented correctly. [IOS] [FIXED] - Use autolinking-generated react-native-config output in second step of cocoapods linking that generates artifacts and generated source Pull Request resolved: #53503 Test Plan: - See #53501 for failing repro - Clone for working repro: https://github.com/byCedric/react-native-codegen-ios-autolinking/tree/fix-54503 - Note: Contains this PR's changes as a patch - `bun install` - `bun expo run:ios` Reviewed By: cortinico Differential Revision: D81490755 Pulled By: cipolleschi fbshipit-source-id: eefe786a116404f4ed24bd7125dfb108a811f71e

react-native-bot · 2025-09-09T13:05:23Z

This pull request was successfully merged by @kitten in a2eb29e

^{When will my fix make it into a release? | How to file a pick request?}

…enerator (#53503)" This reverts commit a2eb29e.

…#53503) Summary: Resolves #53501 This is a pretty major oversight of (presumably) the old autolinking refactor. The iOS autolinking's second stage, invoked in `use_react_native!` does not accept the `react-native-config` sub-command's `react-native-config` output. This is only invoked and used in the prior step, `use_native_modules`. The second step instead invokes old code that does something _similar_ to the new autolinking in `scripts/generate-artifacts-executor`, and happens to align in most cases. (But it does "autolinking" from scratch). tl;dr: When the results don't match up, things go wrong. Instead, we now write the autolinking (react native config) results to a file, then read the output back in the second step. This doesn't affect Android/Gradle, which are implemented correctly. [IOS] [FIXED] - Use autolinking-generated react-native-config output in second step of cocoapods linking that generates artifacts and generated source Pull Request resolved: #53503 Test Plan: - See #53501 for failing repro - Clone for working repro: https://github.com/byCedric/react-native-codegen-ios-autolinking/tree/fix-54503 - Note: Contains this PR's changes as a patch - `bun install` - `bun expo run:ios` Reviewed By: cortinico Differential Revision: D81490755 Pulled By: cipolleschi fbshipit-source-id: eefe786a116404f4ed24bd7125dfb108a811f71e

react-native-bot · 2025-09-10T11:59:48Z

This pull request was successfully merged by @kitten in bb73315

^{When will my fix make it into a release? | How to file a pick request?}

Summary: Follow-up to #53503 for a regression When no React Native module is present this bail condition stops us from generating the artifacts podspec that's needed to complete build. ## Changelog: [IOS] [FIXED] - Fix regression that skips artifacts code generation Pull Request resolved: #53690 Test Plan: - Create an app **without** any React Native modules, run `pod install`; without this fix the podspec will be missing and the build will fail - With expo this can be reproduced using `create-expo-app --template blank-typescript@next` on `[email protected]` - With the community CLI this can be reproduced using `npx react-native-community/cli@latest init test --skip-install --version 0.81.2` and uninstalling `react-native-safe-area-context` Reviewed By: javache Differential Revision: D82103491 Pulled By: cipolleschi fbshipit-source-id: 3d9619b5a935ca920220824b3963a9a107f926ca

…se (#54066) Summary: An earlier change (0.79 and onwards, I believe?) runs the iOS artifacts code generator script in Xcode as well as from Cocoapods. This duplication runs it twice, but the second step isn't able to load the new `autolinking.json` correctly; See: #53503 This PR "double" fixes this by: - simply passing the "real" output directory to the artifacts generator in (`script_phases.sh`) where it's called by Xcode, rather than a temporary directory - preferring `$RCT_SCRIPT_OUTPUT_DIR` if it's set as an environment variable in the artifacts generator (which it is by `script_phases.sh`) While this is technically redundant, future changes here make this feel like a safer option, since both conventions overlap in these two places, and the double fix may prevent a regression here in the shortterm and convey what this path is supposed to be in both places. ## Changelog: [IOS] [FIXED] - Fix autolinking-generated react-native-config output not being used in ReactCodegen script phase due to temp output directory Pull Request resolved: #54066 Test Plan: - Prefer `$RCT_SCRIPT_OUTPUT_DIR` env var for finding `build/generated/autolinking/autolinking.json` - Always use real `$RCT_SCRIPT_OUTPUT_DIR` as output in `withCodegenDiscovery` in `react_native_pods_utils/script_phases.sh` (which is called by Xcode rather than Cocoapods to invoke the artifacts generator) since the temporary output directory isn't necessary Reviewed By: javache Differential Revision: D85673625 Pulled By: cipolleschi fbshipit-source-id: 9d297fb0ee24f52a0bb7c5a8f41bf770bf63b18f

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2025

facebook-github-bot added p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 28, 2025

kitten force-pushed the @kitten/fix/broken-ios-autolinking branch 3 times, most recently from 5c06b10 to 045db60 Compare August 28, 2025 13:57

cipolleschi requested changes Aug 28, 2025

View reviewed changes

packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js Outdated Show resolved Hide resolved

kitten requested a review from cipolleschi August 28, 2025 22:20

cipolleschi requested changes Aug 29, 2025

View reviewed changes

packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js Outdated Show resolved Hide resolved

cipolleschi approved these changes Sep 2, 2025

View reviewed changes

kitten added 3 commits September 2, 2025 08:21

Use autolinking react-native-config output in iOS artifacts generator

5ee2fb1

Always add findProjectRootLibraries

8bc9101

Rename variables for clarity

b03cefe

kitten force-pushed the @kitten/fix/broken-ios-autolinking branch 2 times, most recently from 28de9a8 to c8dfe0d Compare September 2, 2025 07:35

Fix flow/test errors and replace output with codegenLog

a9ab883

kitten force-pushed the @kitten/fix/broken-ios-autolinking branch from c8dfe0d to a9ab883 Compare September 2, 2025 07:49

cipolleschi approved these changes Sep 2, 2025

View reviewed changes

cortinico approved these changes Sep 3, 2025

View reviewed changes

facebook-github-bot closed this in f170db4 Sep 3, 2025

react-native-bot added the Merged This PR has been merged. label Sep 3, 2025

kitten mentioned this pull request Sep 3, 2025

[0.81] Use autolinking react-native-config output in iOS artifacts generator reactwg/react-native-releases#1108

Closed

kitten mentioned this pull request Sep 9, 2025

[iOS] Remove outdated artifacts codegen early return #53690

Closed

gabrieldonadel added a commit that referenced this pull request Sep 9, 2025

Revert "Use autolinking react-native-config output in iOS artifacts g…

537e3ad

…enerator (#53503)" This reverts commit a2eb29e.

kitten mentioned this pull request Sep 10, 2025

fix(expo-modules-autolinking): Force FBReactNativeSpec codegen for source builds when codegen output is missing expo/expo#39512

Merged

3 tasks

This was referenced Sep 10, 2025

[0.81] [iOS] Remove outdated artifacts codegen early return reactwg/react-native-releases#1126

Closed

[0.82] [iOS] Remove outdated artifacts codegen early return reactwg/react-native-releases#1127

Closed

kitten mentioned this pull request Oct 6, 2025

[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066

Closed

cipolleschi mentioned this pull request Oct 14, 2025

[iOS][Fixed][LegacyArch] Fixed Switch component for Legacy Arch #54155

Merged

This was referenced Oct 28, 2025

[0.82] Fix outputs when iOS artifacts generator is run from Xcode script phase reactwg/react-native-releases#1159

Open

[0.81] Fix outputs when iOS artifacts generator is run from Xcode script phase reactwg/react-native-releases#1160

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[iOS] Use autolinking react-native-config output in iOS artifacts generator #53503

[iOS] Use autolinking react-native-config output in iOS artifacts generator #53503

Uh oh!

kitten commented Aug 28, 2025 •

edited

Loading

Uh oh!

cipolleschi left a comment

Uh oh!

Uh oh!

kitten commented Aug 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

cipolleschi left a comment •

edited

Loading

Uh oh!

kitten commented Sep 2, 2025

Uh oh!

facebook-github-bot commented Sep 2, 2025

Uh oh!

cortinico left a comment

Uh oh!

react-native-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

react-native-bot commented Sep 9, 2025

Uh oh!

react-native-bot commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[iOS] Use autolinking react-native-config output in iOS artifacts generator #53503

[iOS] Use autolinking react-native-config output in iOS artifacts generator #53503

Uh oh!

Conversation

kitten commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

cipolleschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kitten commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cipolleschi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kitten commented Sep 2, 2025

Uh oh!

facebook-github-bot commented Sep 2, 2025

Uh oh!

cortinico left a comment

Choose a reason for hiding this comment

Uh oh!

react-native-bot commented Sep 3, 2025

Uh oh!

facebook-github-bot commented Sep 3, 2025

Uh oh!

react-native-bot commented Sep 9, 2025

Uh oh!

react-native-bot commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kitten commented Aug 28, 2025 •

edited

Loading

kitten commented Aug 28, 2025 •

edited

Loading

cipolleschi left a comment •

edited

Loading