Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.75] Fix Symlinks in Hermes #461

Closed
cipolleschi opened this issue Sep 3, 2024 · 1 comment
Closed

[0.75] Fix Symlinks in Hermes #461

cipolleschi opened this issue Sep 3, 2024 · 1 comment

Comments

@cipolleschi
Copy link
Collaborator

Target Branch(es)

0.75

Link to commit or PR to be picked

facebook/react-native#46301

Description

When building hermes on GH actions, we store the iOS slices as artifacts using the GHA upload-artifacts action.
When uploading a folder, the upload-artifacts action follow the symlinks and copies and pastes the content of the links instead of preserving the Symlink itself.
This breaks the xcframework for macOS and catalyst.

We fixed this by compressing the folder and then uploading the tarball instead of the original folder.

@cipolleschi
Copy link
Collaborator Author

Picked ✅

@github-project-automation github-project-automation bot moved this from Inbox to Done / Picked in React Native 0.75 Releases Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done / Picked
Development

No branches or pull requests

1 participant