Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOCAL] fix/0.75 stable windows cmake #48139

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Dec 6, 2024

Do not install CMake on Windows machine

This replicates a fix in 00d5cae. 0.75 hadn't factored this out into a separate action.

Changelog: [Internal]

This covers all instances:

$ git grep 'choco install --no-progress cmake' | wc -l
0

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@blakef blakef changed the base branch from main to 0.75-stable December 6, 2024 10:51
@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 0b66504

@blakef blakef requested a review from cipolleschi December 6, 2024 10:52
Copy link

github-actions bot commented Dec 6, 2024

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 6e715c0

This replicates a fix in 00d5cae. 0.75 hadn't factored this out into
a separate action.
@blakef blakef force-pushed the fix/0.75-stable-windows-cmake branch from 0b66504 to 6e715c0 Compare December 6, 2024 10:52
@blakef blakef changed the title fix/0.75 stable windows cmake [LOCAL] fix/0.75 stable windows cmake Dec 6, 2024
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cipolleschi cipolleschi merged commit a2d8cbf into 0.75-stable Dec 6, 2024
14 of 21 checks passed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,743,798 -611,058
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,945,550 -604,441
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android - aliasing on borderRadius
5 participants