-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/hermes in release #34223
Fix/hermes in release #34223
Conversation
c120db2
to
4338826
Compare
Base commit: d0b1d49 |
Summary: This Diff is a copy of this [PR](facebook#34223) that we have against 0.69-stable. This Diff introduces some checks to prevent that we try to copy folders that are not present. ## Changelog Avoid copying the folders when they are not there. [General] [Changed] - When preparing the Hermes workspace, we don't copy the folders that are not present. Differential Revision: D37961092 fbshipit-source-id: f52f73a53a93dcb549d5c5cbf714e3ba242ada9a
4338826
to
d6be1af
Compare
@cipolleschi do you rekon we need to wait for this to land to do 0.69.2 or we could proceed without? We are planning to push it out tomorrow morning |
@kelset I'm working on this to unblock @Kudo on #34214. If we need #34214, then yes, this should be included, otherwise we can't know whether the other PR break the CI or not. The bad thing is that the CI will take 2 hours to finish, but given that we are targeting 0.69-stable, we don't have to import this in |
ok, no rush - worst case we can do a separate 0.69.3 :) |
Summary
The
prepare_hermes_workspace
has aDownload Hermes Tarball
that downloads the tarball to build hermes from source only in some circumstances. When we have a PR that runs against X.YY-stable, the download does not happens. However, the CI expect to have a couple of folder and tries to move them.When the download does not happens, these folders are not there and therefore the CI fails.
This PR should fix the issue: when the download does not happen, we don't try to copy these folders.
Changelog
Avoid copying the folders when they are not there.
[General] [Changed] - When preparing the Hermes workspace, we don't copy the folders that are not present.
Test Plan
The CI should be green.