fix: make sure we can build hermes when working against stable

.circleci/config.yml

@@ -937,8 +937,17 @@ jobs:
           name: Download Hermes tarball
           command: |
             node scripts/hermes/prepare-hermes-for-build
-            cp sdks/download/* $HERMES_WS_DIR/download/.
-            cp -r sdks/hermes/* $HERMES_WS_DIR/hermes/.
+
+            # If Hermes is not built from source, we don't have these folders.
+            DOWNLOAD_FOLDER=sdks/download/
+            if [[ -d $DOWNLOAD_FOLDER ]]; then
+              cp $DOWNLOAD_FOLDER* $HERMES_WS_DIR/download/.
+            fi
+
+            HERMES_FOLDER=sdks/hermes/
+            if [[ -d $HERMES_FOLDER ]]; then
+              cp -r $HERMES_FOLDER* $HERMES_WS_DIR/hermes/.
+            fi
       - save_cache:
           key: v1-hermes-{{ .Environment.CIRCLE_JOB }}-{{ checksum "/tmp/hermes/hermesversion" }}
           paths:

scripts/hermes/hermes-utils.js

@@ -192,10 +192,19 @@ function isOnAReleaseTag() {
 
 function shouldBuildHermesFromSource() {
   const hermesTag = readHermesTag();
+
+  const onReleaseBranch = isOnAReleaseBranch();
+  const onReleaseTag = isOnAReleaseTag();
+  const hermesTagIsDefault = hermesTag === DEFAULT_HERMES_TAG;
+
+  // Logging for CI Debugging
+  console.log(`[Hermes] On release branch? ${onReleaseBranch ? "Yes" : "No"}`)
+  console.log(`[Hermes] On release tag? ${onReleaseTag ? "Yes" : "No"}`)
+  console.log(`[Hermes] Hermes Tag is Default? ${hermesTagIsDefault ? "Yes" : "No"}`)
   return (
-    isOnAReleaseBranch() ||
-    isOnAReleaseTag() ||
-    hermesTag === DEFAULT_HERMES_TAG
+    onReleaseBranch ||
+    onReleaseTag ||
+    hermesTagIsDefault
   );
 }
 

scripts/hermes/prepare-hermes-for-build.js

@@ -25,6 +25,7 @@ const {
 
 async function main() {
   if (!shouldBuildHermesFromSource()) {
+    console.log('[Hermes] Not building from Source')
     copyPodSpec();
     return;
   }