fix: make sure we can build hermes when working against stable

facebook · Jul 19, 2022 · d6be1af · d6be1af
1 parent a19578d
commit d6be1af
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -937,8 +937,17 @@ jobs:
           name: Download Hermes tarball
           command: |
             node scripts/hermes/prepare-hermes-for-build
-            cp sdks/download/* $HERMES_WS_DIR/download/.
-            cp -r sdks/hermes/* $HERMES_WS_DIR/hermes/.
+
+            # If Hermes is not built from source, we don't have these folders.
+            DOWNLOAD_FOLDER=sdks/download/
+            if [[ -d $DOWNLOAD_FOLDER ]]; then
+              cp $DOWNLOAD_FOLDER* $HERMES_WS_DIR/download/.
+            fi
+
+            HERMES_FOLDER=sdks/hermes/
+            if [[ -d $HERMES_FOLDER ]]; then
+              cp -r $HERMES_FOLDER* $HERMES_WS_DIR/hermes/.
+            fi
       - save_cache:
           key: v1-hermes-{{ .Environment.CIRCLE_JOB }}-{{ checksum "/tmp/hermes/hermesversion" }}
           paths:

diff --git a/scripts/hermes/hermes-utils.js b/scripts/hermes/hermes-utils.js
@@ -192,6 +192,7 @@ function isOnAReleaseTag() {
 
 function shouldBuildHermesFromSource() {
   const hermesTag = readHermesTag();
+
   return (
     isOnAReleaseBranch() ||
     isOnAReleaseTag() ||