Android CI: Fix up //packages/react-native-codegen:setup_cli src copy issue #30259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D24577333 |
|
Base commit: 36b0f7d |
Summary: Pull Request resolved: facebook#30259 Before side-by-side NDK is supported by the Circle CI image, pending facebook#29050 & facebook#29987, this local.properties file forces Gradle to use the specified SDK/NDK path. We do this internally at FB CI as well. This addresses the following failure: https://app.circleci.com/pipelines/github/facebook/react-native/6851/workflows/9fd91d5d-3f05-4521-93fc-95abd5c84227/jobs/173735 Also, this fixed bad src copy for Buck-building: `//packages/react-native-codegen:setup_cli` Changelog: [Internal] Reviewed By: hramos Differential Revision: D24577333 fbshipit-source-id: 93f11c3e3a3f699415739d0760ee10909eb748ed
fkgozali
force-pushed
the
export-D24577333
branch
from
9a5d612 to
35cd11f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D24577333 |
fkgozali
referenced
this pull request
Oct 27, 2020
Summary: The recursive copy statement fixed here behaved differently in MacOS vs Linus (CI), because of the missing dot (.) The trailing slash on the source directory behaves differently on Mac (BSD) than Linux (GNU): > If the source_file ends in a /, the contents of the directory are copied rather than the directory itself. This should fix the CI failure: https://app.circleci.com/pipelines/github/facebook/react-native/6847/workflows/36d59aab-bc4a-4d21-9ce1-a8348e71aea3/jobs/173681 Changelog: [Internal] Reviewed By: RSNara Differential Revision: D24560543 fbshipit-source-id: c3ab2c28616b717891bcf5d2ad762340cfb97e3d
Contributor
Author
|
The NDK error went away, then the remaining failure is pending Node v12 upgrade: https://app.circleci.com/pipelines/github/facebook/react-native/6869/workflows/f694be41-d915-4af1-8e82-5e4ae437ef29/jobs/173977 |
fkgozali
referenced
this pull request
Oct 27, 2020
Summary: This does a few things: * Remove USE_CODEGEN flag so that TurboModule is enabled by default for RNTester * Use the codegen output for Java/JNI spec files * Remove the checked in com.facebook.fbreact.specs Java/JNI files Changelog: [Changed][Android] RNTester now enables TurboModule by default using codegen. Reviewed By: RSNara Differential Revision: D24382083 fbshipit-source-id: 87e3e0581bac3287ef01c1a0deb070c1d7d40f2d
Contributor
Author
|
Repurposing this PR to fix Buck failure. NDK and Node 12 issues will be fixed by #30252 |
fkgozali
changed the title
gengjiawen
approved these changes
Oct 28, 2020
Contributor
Author
|
This landed separately: 3a41125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixed bad src copy for Buck-building: //packages/react-native-codegen:setup_cli. Using rsync -L will correctly copy file contents instead of preserving symlinks (which confused yarn).
Changelog: [Internal]
Differential Revision: D24577333