Skip to content

Android CI: Fix up //packages/react-native-codegen:setup_cli src copy issue #30259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fkgozali wants to merge 1 commit into from
Closed

Android CI: Fix up //packages/react-native-codegen:setup_cli src copy issue #30259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-codegen/DEFS.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def rn_codegen_cli():
bash = r"""
set -euo pipefail
mkdir -p "$OUT"
cp -r "$SRCDIR/." "$OUT/"
rsync -rLptgoD "$SRCDIR/" "$OUT"
cd "$OUT"
yarn install 2> >(grep -v '^warning' 1>&2)
yarn run build
Expand Down
13 changes: 13 additions & 0 deletions scripts/validate-android-test-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
# the android sdk that is actually installed. Also, we must have the
# right version of Java.

THIS_DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOURCE[0]}")")" && pwd)

# Check that Buck is working.
if [ -z "$(which buck)" ]; then
echo "You need to install Buck."
Expand Down Expand Up @@ -115,3 +117,14 @@ if [ -z "$JAVA_HOME" ]; then
echo "You will also want to add \$JAVA_HOME/bin to your path."
exit 1
fi

# Assuming Android SDK/NDK has been set up, set up `local.properties` file
# to force Gradle to use the provided versions. This is necessary before
# the side-by-side NDK installation is supported for Circle CI runs.
LOCAL_PROPERTIES="$THIS_DIR/../local.properties"
if [ ! -f "$LOCAL_PROPERTIES" ]; then
echo "Setting up local.properties for NDK builds."
touch "$LOCAL_PROPERTIES"
echo "sdk.dir=$ANDROID_HOME" >> "$LOCAL_PROPERTIES"
echo "ndk.dir=$ANDROID_NDK" >> "$LOCAL_PROPERTIES"
fi