CI: use react-native-android:2020-6-4 docker image

[dulmandakh]

Summary

In react-native-community/docker-android@b9ea45f, we bumped Buck to 2020.05.14.01, NDK to 20.1.5948944.

Changelog

[Internal] [Changed] - CI: use react-native-android:2020-6-4 docker image, with Buck 2020.05.14.01 and Android NDK 20.1.5948944

Test Plan

CI must be green

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: abff021

[gengjiawen]

test_android is failing since the avd not start, I am restarting it to see retry result.

[fabOnReact]

The error circle-ci is experiencing now is:

#!/bin/bash -eo pipefail
source scripts/android-setup.sh && waitForAVD
Waiting for Android Virtual Device to finish booting...
Exited with code exit status 1
CircleCI received exit code 1

The emulator starts without issue in the job Launch Android Virtual Device in Background:

#!/bin/bash -eo pipefail
source scripts/android-setup.sh && launchAVD
emulator: WARNING: encryption is off
emulator: ERROR: AdbHostServer.cpp:102: Unable to connect to adb daemon on port: 5037
E0608 01:55:04.623296305     598 socket_utils_common_posix.cc:201] check for SO_REUSEPORT: {"created":"@1591581304.623273827","description":"SO_REUSEPORT unavailable on compiling system","file":"/mnt/tmpfs/src/android/emu-master-dev/external/grpc/src/core/lib/iomgr/socket_utils_common_posix.cc","file_line":169}
Your emulator is out of date, please update by launching Android Studio:
 - Start Android Studio
 - Select menu "Tools > Android > SDK Manager"
 - Click "SDK Tools" tab
 - Check "Android Emulator" checkbox
 - Click "OK"
saving arm snapshot.... !!!
emulator: Saving state on exit with session uptime 948997 ms
Build was canceled

Maybe the issue is connected to waitForAVD ?

react-native/scripts/android-setup.sh

Lines 67 to 77 in e1cfead

	function waitForAVD {
	echo "Waiting for Android Virtual Device to finish booting..."
	local bootanim=""
	export PATH=$(dirname $(dirname $(command -v android)))/platform-tools:$PATH
	until [[ "$bootanim" =~ "stopped" ]]; do
	sleep 5
	bootanim=$(adb -e shell getprop init.svc.bootanim 2>&1)
	echo "boot animation status=$bootanim"
	done
	echo "Android Virtual Device is ready."
	}

Thanks a lot
I wish you a good day
Fabrizio

[fabOnReact]

I checkout out your branch head 57993a5110 and I run locally

➜  react-native git:(57993a5110) source scripts/android-setup.sh && launchAVD
emulator: WARNING: encryption is off
emulator: INFO: VideoFrameSharer.cpp:76: Initialized handle: videmulator5554
emulator: INFO: WebRtcBridge.cpp:263: Launching: /home/fabrizio/Android/Sdk/emulator/goldfish-webrtc-bridge --daemon --logdir /tmp/android-fabrizio --port 34377 --handle videmulator5554 --turn
emulator: INFO: WebRtcBridge.cpp:273: Launched /home/fabrizio/Android/Sdk/emulator/goldfish-webrtc-bridge --daemon --logdir /tmp/android-fabrizio --port 34377 --handle videmulator5554 --turn  , pid:21958
emulator: WARNING: EmulatorService.cpp:448: Cannot find certfile: /home/fabrizio/.android/emulator-grpc.cer security will be disabled.
E0608 11:23:49.186321122   21941 socket_utils_common_posix.cc:201] check for SO_REUSEPORT: {"created":"@1591608229.186287598","description":"SO_REUSEPORT unavailable on compiling system","file":"/mnt/tmpfs/src/android/emu-master-dev/external/grpc/src/core/lib/iomgr/socket_utils_common_posix.cc","file_line":169}
Started GRPC server at 127.0.0.1:8554

At the same time I run in another session waitForAVD and it works fine

➜  react-native git:(57993a5110) source scripts/android-setup.sh && waitForAVD
Waiting for Android Virtual Device to finish booting...
boot animation status=stopped
Android Virtual Device is ready.

Output without running launchAvd command

➜  react-native git:(57993a5110) ✗ source scripts/android-setup.sh && waitForAVD
Waiting for Android Virtual Device to finish booting...
boot animation status=adb: no emulators found
boot animation status=adb: no emulators found
boot animation status=adb: no emulators found

All this commands are run after createAVD.

[hramos]

I've rebased on top of master. test_android failing at the AVD creation step, it looks like we might need to adjust that:

source scripts/android-setup.sh && launchAVD
emulator: WARNING: encryption is off
emulator: ERROR: AdbHostServer.cpp:102: Unable to connect to adb daemon on port: 5037
E0925 00:22:26.296880951     586 socket_utils_common_posix.cc:201] check for SO_REUSEPORT: {"created":"@1600993346.296870234","description":"SO_REUSEPORT unavailable on compiling system","file":"/mnt/tmpfs/src/android/emu-master-dev/external/grpc/src/core/lib/iomgr/socket_utils_common_posix.cc","file_line":169}
Your emulator is out of date, please update by launching Android Studio:
 - Start Android Studio
 - Select menu "Tools > Android > SDK Manager"
 - Click "SDK Tools" tab
 - Check "Android Emulator" checkbox
 - Click "OK"

https://app.circleci.com/pipelines/github/facebook/react-native/6481/workflows/495a3e4d-ce2b-4604-8a24-d6afa2338339/jobs/169310

[fkgozali]

@dulmandakh let's update this per @hramos' comment, then we can merge other pending PRs that are waiting for this.

Also, should we update the image to include NDK v21 based on discussion in #29013?

[dulmandakh]

I'll add NDK 21 on top of 20 to facilitate migration, and update this PR very soon. Thanks