Skip to content

CI: use react-native-android:2020-6-4 docker image #29050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dulmandakh wants to merge 3 commits into from
Closed

CI: use react-native-android:2020-6-4 docker image #29050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8f764b
bump react-native-android to 2020-6-4
dulmandakh Jun 4, 2020
57993a5
set BUCK_EXPECTED_VERSION=
dulmandakh Jun 4, 2020
ef4897e
Merge branch 'master' into android-docker-2020-6-4
hramos Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ executors:
reactnativeandroid:
<<: *defaults
docker:
- image: reactnativecommunity/react-native-android:2019-10-18
- image: reactnativecommunity/react-native-android:2020-6-4
resource_class: "large"
environment:
- TERM: "dumb"
Expand Down
14 changes: 7 additions & 7 deletions scripts/validate-android-test-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ if [ -z "$(buck --version)" ]; then
fi
exit 1
else
BUCK_EXPECTED_VERSION="buck version d743d2d0229852ce7c029ec257532d8916f6b2b7"
BUCK_EXPECTED_VERSION="buck version 2020.05.14.01"
if [ "$(buck --version)" != "$BUCK_EXPECTED_VERSION" ]; then
if [ ! -d "/opt/facebook" ]; then
echo "Warning: The test suite expects ${BUCK_EXPECTED_VERSION} to be installed"
Expand Down Expand Up @@ -109,9 +109,9 @@ if [ -n "$(which csrutil)" ]; then
fi
fi

if [ -z "$JAVA_HOME" ]; then
echo "Error: \$JAVA_HOME is not configured."
echo "Try adding export JAVA_HOME=\$(/usr/libexec/java_home) to your .bashrc or equivalent."
echo "You will also want to add \$JAVA_HOME/bin to your path."
exit 1
fi
# if [ -z "$JAVA_HOME" ]; then
# echo "Error: \$JAVA_HOME is not configured."
# echo "Try adding export JAVA_HOME=\$(/usr/libexec/java_home) to your .bashrc or equivalent."
# echo "You will also want to add \$JAVA_HOME/bin to your path."
# exit 1
# fi