Optimize native animated connection queue handling #25256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
msand
force-pushed
the
optimize-native-animated-connection-queue
branch
from
834fa1c to
d036e0b
Compare
Change O(n^2) to O(n)
msand
force-pushed
the
optimize-native-animated-connection-queue
branch
from
d036e0b to
22efa3b
Compare
|
Hmm, why does js_coverage fail with: Test Suites: 90 passed, 90 total /home/circleci/react-native/node_modules/coveralls/bin/coveralls.js:18 |
cpojer
approved these changes
Jun 13, 2019
facebook-github-bot
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @msand in 206abb0. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: Change O(n^2) to O(n) Minor follow-up to: facebook#24177 ## Changelog [Internal] [Changed] - Optimize native animated connection queue handling Pull Request resolved: facebook#25256 Differential Revision: D15804527 Pulled By: cpojer fbshipit-source-id: 4a1e1b51faf6ed7b98eb08aa47e18cfaea541dad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change O(n^2) to O(n)
Summary
Minor follow-up to: #24177
Changelog
[Internal] [Changed] - Optimize native animated connection queue handling
Test Plan
Run CI